Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHANGELOG for Rust 1.50 #6520

Merged
merged 2 commits into from Jan 2, 2021
Merged

Update CHANGELOG for Rust 1.50 #6520

merged 2 commits into from Jan 2, 2021

Conversation

phansch
Copy link
Member

@phansch phansch commented Dec 30, 2020

changelog: none

r? @flip1995

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 30, 2020
flip1995
flip1995 reviewed Dec 30, 2020
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually sort the entries in the sections by PR numbers, but that's just my OCD, I guess 😄

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@phansch
Copy link
Member Author

phansch commented Dec 30, 2020 •
edited

I usually sort the entries in the sections by PR numbers, but that's just my OCD, I guess

Ah right, I used to sort the entries by lint names, but I didn't bother this time around 🤷 Let me know if you'd still prefer the entries sorted in some way =)
We could perhaps add the sorting to the shell script as well?

flip1995
flip1995 approved these changes Dec 30, 2020
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! As always: I'll merge this at the end of the release process.

(It doesn't have to be sorted. 1.48 wasn't sorted either, so we're not consistent in this regard anyway 🤷‍♂️)

djc
djc reviewed Dec 30, 2020
View reviewed changes
CHANGELOG.md
* You can now tell Clippy about the MSRV your project supports. Please refer to
the specific README section to learn more about MSRV support [here][msrv_readme]
[#6201](https://github.com/rust-lang/rust-clippy/pull/6201)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a big thing that's all the way down at the end. Shouldn't it be up there near the top?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to release a blog post about this. I prefer the structure of the changelog we currently have.

I want to write the blog post some time before 1.50.

@flip1995
Copy link
Member

flip1995 commented Jan 2, 2021

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Jan 2, 2021

📌 Commit b81111b has been approved by flip1995

@bors
Copy link
Contributor

bors commented Jan 2, 2021

⌛ Testing commit b81111b with merge 78f6009...

@bors
Copy link
Contributor

bors commented Jan 2, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 78f6009 to master...

@bors bors merged commit 78f6009 into rust-lang:master Jan 2, 2021
1 check passed
@phansch phansch deleted the update-changelog branch January 2, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc left review comments

@flip1995 flip1995 flip1995 approved these changes

Assignees

@flip1995 flip1995

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@phansch @flip1995 @bors @djc @rust-highfive