Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual_unwrap_or: fix invalid code suggestion, due to macro expansion #7136

Conversation

mgacek8
Copy link
Contributor

@mgacek8 mgacek8 commented Apr 26, 2021

fixes #6965

changelog: fix invalid code suggestion in manual_unwrap_or lint, due to macro expansion

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 26, 2021
@mgacek8 mgacek8 force-pushed the issue6965_manual_unwrap_or_invalid_sugg_macro_expansion branch from 53eeb29 to 84003aa Compare April 26, 2021 19:19
@llogiq
Copy link
Contributor

llogiq commented Apr 26, 2021

Thank you! @bors r+

@bors
Copy link
Collaborator

bors commented Apr 26, 2021

📌 Commit 84003aa has been approved by llogiq

@bors
Copy link
Collaborator

bors commented Apr 26, 2021

⌛ Testing commit 84003aa with merge 0a330e6...

@bors
Copy link
Collaborator

bors commented Apr 26, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 0a330e6 to master...

@bors bors merged commit 0a330e6 into rust-lang:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manual_unwrap_or hint suggest invalid code, due to macro expansion
4 participants