Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize cargo clippy --fix #7405

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Stabilize cargo clippy --fix #7405

merged 1 commit into from
Jun 29, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jun 26, 2021

This has been unstable since it was first introduced in
#5363. In that time, I have
been using it successfully in nightly without issues. I don't think
there are any blocking issues now that RUSTC_WORKSPACE_WRAPPER is
stabilized, so this can be stabilized.

changelog: Stabilize cargo clippy --fix

@rust-highfive
Copy link

r? @camsteffen

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 26, 2021
@jyn514
Copy link
Member Author

jyn514 commented Jun 26, 2021

I don't know what the process is for stabilizing things, so 🤷 cc @rust-lang/clippy

@Manishearth
Copy link
Member

I'm +1 for this, woudl love to see what others think

@matthiaskrgr
Copy link
Member

There are a couple of other places that need to be updated as well I think?

.github/workflows/clippy.yml and .github/workflows/clippy_bors.yml (We test --fix there)
Readme.md still mentions -Zunstable-options
Lintcheck also utilizes --fix -Zunstable options lintcheck/src/main.rs

git grep "\-\-fix" should find most of the occurrences.

Looking forward to having this merged! 😄

@jyn514 jyn514 force-pushed the fix-stable branch 3 times, most recently from 93a5e1c to 17fbb56 Compare June 26, 2021 13:32
@jyn514
Copy link
Member Author

jyn514 commented Jun 26, 2021

This is ready for re-review :)

giraffate
giraffate approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

flip1995
flip1995 approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also +1 from me

src/main.rs Outdated Show resolved Hide resolved
@jyn514
Stabilize cargo clippy --fix
aa40487 
This has been unstable since it was first introduced in
rust-lang#5363. In that time, I have
been using it successfully in nightly without issues. I don't think
there are any blocking issues now that RUSTC_WORKSPACE_WRAPPER is
stabilized, so this can be stabilized.
@camsteffen
Copy link
Contributor

@bors r+

Thanks @jyn514!

@bors
Copy link
Collaborator

bors commented Jun 29, 2021

📌 Commit aa40487 has been approved by camsteffen

@bors
Copy link
Collaborator

bors commented Jun 29, 2021

⌛ Testing commit aa40487 with merge 95c2ab7...

@bors
Copy link
Collaborator

bors commented Jun 29, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: camsteffen
Pushing 95c2ab7 to master...

@bors bors merged commit 95c2ab7 into rust-lang:master Jun 29, 2021
@jyn514 jyn514 deleted the fix-stable branch June 29, 2021 13:21
@jyn514
Copy link
Member Author

jyn514 commented Jun 29, 2021

Thank you all for making Clippy great! ❤️

@camsteffen
Copy link
Contributor

Awww 🥺

@dconnolly dconnolly mentioned this pull request Sep 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

@camsteffen camsteffen camsteffen approved these changes

@flip1995 flip1995 flip1995 approved these changes

@xFrednet xFrednet xFrednet approved these changes

@giraffate giraffate giraffate approved these changes

Assignees

@camsteffen camsteffen

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jyn514 @rust-highfive @Manishearth @matthiaskrgr @camsteffen @bors @flip1995 @xFrednet @giraffate