Don't lint Default::default if it is the udpate syntax base

[hellow554]

changelog: Don't lint Default::default if it is part of the update syntax

Current clippy warns about this:

warning: calling `Foo::default()` is more clear than this expression
  --> src/main.rs:12:11
   |
12 |         ..Default::default()
   |           ^^^^^^^^^^^^^^^^^^ help: try: `Foo::default()`
   |

With these changes, it will not lint that particular expression anymore.

[rust-highfive]

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

[hellow554]

friendly ping @flip1995

[flip1995]

Sorry, I'm currently really busy with my $day_job :/

What's the reasoning behind not linting this case? Is there an issue about it?

Impl LGTM, except for the position in the if_chain, see comment above.

[hellow554]

Sorry, I'm currently really busy with my $day_job :/

Oh. This doesn't have to hurry, it can rest one week or more ;)

What's the reasoning behind not linting this case? Is there an issue about it?

Sort of.
Fields assign with default recommends using the .. Default::default() syntax explicitly and TBH you already write Foo { .... }, which means it is obvious which type you are currently try to default. It should be the same reasoning as with <Foo as Default>::default:

rust-clippy/clippy_lints/src/default.rs

Line 91 in b34cd79

// Detect and ignore <Foo as Default>::default() because these calls do explicitly name the type.

Impl LGTM, except for the position in the if_chain, see comment above.

I moved it down right after the check that that expression is a default call. Thanks for that.

[flip1995]

That's a convincing argument 👍

Thanks!

@bors r+

[bors]

📌 Commit 504f3af has been approved by flip1995

[bors]

⌛ Testing commit 504f3af with merge a4cf91b...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing a4cf91b to master...