indexing_slicing should not fire if a valid array index comes from a constant function that is evaluated at compile-time
#8588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- should not fire if indexing with a constant block - should not fire if indexing within a constant context (const statement or const block)
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
bors
added a commit
that referenced
this pull request
Mar 30, 2022
Do not fire `panic` in a constant environment Let rustc handle panics in constant environments. Since #8348 I thought that such modification would require a lot of work but thanks to #8588 I now know that it is not the case. changelog: [`panic`]: No longer lint in constant context. `rustc` already handles this.
|
@flip1995 bump |
|
@bors r+ Thanks! Sorry for the delay. |
|
📌 Commit 21eae8c has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8348
changelog: [
indexing_slicing] fewer false positives inconstcontexts and withconstindices