Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[arithmetic-side-effects] Finish non-overflowing ops #9483

Merged
merged 3 commits into from Sep 19, 2022

Conversation

c410-f3r
Copy link
Contributor

Extends #9474 to also take into consideration "raw" binary operations. For example, let a = b / 2 and let a = 1 * b won't trigger the lint.

changelog: [arithmetic-side-effects] Finish non-overflowing ops

@rust-highfive
Copy link

r? @Jarcho

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 15, 2022
@Jarcho
Copy link
Contributor

Jarcho commented Sep 19, 2022

Thank you. @bors r+

@bors
Copy link
Collaborator

bors commented Sep 19, 2022

📌 Commit b7bef4c has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 19, 2022

⌛ Testing commit b7bef4c with merge 5c3c6a2...

@bors
Copy link
Collaborator

bors commented Sep 19, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing 5c3c6a2 to master...

@bors bors merged commit 5c3c6a2 into rust-lang:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants