Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc_tools_util: bump version in anticipation of a new release #9561

Closed
wants to merge 1 commit into from

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Sep 30, 2022

cc #9553

After this is merged, I will publish the 0.2.1 version to crates.io, and make another PR that switches clippy to use the dependency from crates.io.
The source can still be kept in the clippy repo though imo.

This will allow miri and clippy to "share" the crate in the rustc repo once they both depend on it.

changelog: release rustc_tools_util on Crates.io.

@rust-highfive
Copy link

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 30, 2022
@flip1995
Copy link
Member

flip1995 commented Oct 1, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 1, 2022

📌 Commit ef6adc2 has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 1, 2022

⌛ Testing commit ef6adc2 with merge 58d9f1e...

bors added a commit that referenced this pull request Oct 1, 2022
rustc_tools_util: bump version in anticipation of a new release

cc #9553

After this is merged, I will publish the 0.2.1 version to crates.io, and make another PR that switches clippy to use the dependency from crates.io.
The source can still be kept in the clippy repo though imo.

This will allow miri and clippy to "share" the crate in the rustc repo once they both depend on it.
build = "build.rs"
````

List rustc_tools_util as regular AND build dependency.
````
````toml
[dependencies]
rustc_tools_util = "0.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rustc_tools_util = "0.1"
rustc_tools_util = "0.2.1"

@bors
Copy link
Collaborator

bors commented Oct 1, 2022

💔 Test failed - checks-action_test

@flip1995
Copy link
Member

flip1995 commented Oct 1, 2022

@bors r- retry

@flip1995
Copy link
Member

flip1995 commented Oct 1, 2022

r=me with the comment addressed

@matthiaskrgr
Copy link
Member Author

@bors r=flip1995

@bors
Copy link
Collaborator

bors commented Oct 1, 2022

📌 Commit cf44aec has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 1, 2022

⌛ Testing commit cf44aec with merge 2311cee...

bors added a commit that referenced this pull request Oct 1, 2022
rustc_tools_util: bump version in anticipation of a new release

cc #9553

After this is merged, I will publish the 0.2.1 version to crates.io, and make another PR that switches clippy to use the dependency from crates.io.
The source can still be kept in the clippy repo though imo.

This will allow miri and clippy to "share" the crate in the rustc repo once they both depend on it.

changelog: release `rustc_tools_util` on `Crates.io`.
@matthiaskrgr
Copy link
Member Author

@bors r-

@matthiaskrgr
Copy link
Member Author

I forgot to git add 😅

@matthiaskrgr
Copy link
Member Author

matthiaskrgr commented Oct 1, 2022

Hm, why doesn't it let me reopen the pr...

Looks like when you close a pr and force-push, it doesn't let you reopen it, weird.

bors added a commit that referenced this pull request Oct 1, 2022
rustc_tool_utils: bump version in anticipation of a new release

cc #9553

After this is merged, I will publish the 0.2.1 version to crates.io, and make another PR that switches clippy to use the dependency from crates.io.
The source can still be kept in the clippy repo though imo.

This will allow miri and clippy to "share" the crate in the rustc repo once they both depend on it.

reopen of #9561

changelog: release `rustc_tools_util` on `Crates.io`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants