Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint::unsafe_removed_from_name: fix false positive result when allowed #9593

Merged
merged 1 commit into from
Oct 6, 2022
Merged

lint::unsafe_removed_from_name: fix false positive result when allowed #9593

merged 1 commit into from
Oct 6, 2022

Conversation

Andy-Python-Programmer
Copy link
Contributor

changelog: [unsafe_removed_from_name] Fix allowing on imports produces a false positive on useless_attribute.

Fixes: #9197

Signed-off-by: Andy-Python-Programmer andypythonappdeveloper@gmail.com

* Allowing `unsafe_removed_from_name` on imports produces a false
positive on `useless_attribute`.

Fixes: #9197

Signed-off-by: Andy-Python-Programmer <andypythonappdeveloper@gmail.com>
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @llogiq (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 5, 2022
@llogiq
Copy link
Contributor

llogiq commented Oct 6, 2022

Thank you!

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 6, 2022

📌 Commit 14f9f2b has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 6, 2022

⌛ Testing commit 14f9f2b with merge 8f1ebdd...

@bors
Copy link
Collaborator

bors commented Oct 6, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 8f1ebdd to master...

@bors bors merged commit 8f1ebdd into rust-lang:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useless_attribute with unsafe_rename
4 participants