a few small syntax checking improvements #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Again please can you add some tests to https://github.com/rust-lang/rust-enhanced/blob/master/syntax_test_rust.rs |
Author
|
That should do it |
|
looks good to me |
urschrei
pushed a commit
to urschrei/sublime-rust
that referenced
this pull request
Jan 30, 2018
* a few small syntax checking improvements * use variables in storage type * add exponent syntax tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only really important bit of this is
\b(\d[\d_]*(?:\.[\d_]+)?[eE][-+]?[\d_]+)({{float_suffixes}})?\bwhich now matches literals like1e8. There's probably a simpler way of solving it but I couldn't find it.The other changes are just small performance improvements I noticed.
All the syntax checks passed:
Success: 3554 assertions in 1 files passed.