Skip to content

Handle thread IDs in panic output #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psibi merged 1 commit into from
May 21, 2026
Merged

Handle thread IDs in panic output #588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions rust-compile.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,10 @@ See `compilation-error-regexp-alist' for help on their format.")
See `compilation-error-regexp-alist' for help on their format.")

(defvar rustc-panics-compilation-regexps
(let ((re (concat "thread '[^']+' panicked at " rustc-compilation-location)))
(cons re '(2 3 4 nil 1)))
"Specifications for matching panics in rustc invocations.
(let ((re (concat "thread '[^']+'\\(?: ([0-9]+)\\)? panicked at "
rustc-compilation-location)))
(cons re '(2 3 4 nil 1)))
"Specifications for matching panics in rustc invocations.
See `compilation-error-regexp-alist' for help on their format.")

;; Match test run failures and panics during compilation as
Expand Down
4 changes: 3 additions & 1 deletion rust-mode-tests.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3715,6 +3715,7 @@ let b = 1;"
(insert "note: `ZZZ` could also refer to the constant imported here -> b\n --> file4.rs:12:34\n\n")
(insert " ::: file5.rs:12:34\n\n")
(insert "thread 'main' panicked at src/file7.rs:12:34:\n\n")
(insert "thread 'aaa::bbb' (19178688) panicked at crates/a/src/b.rs:13:9:\n\n")
(insert "[src/file8.rs:159:5] symbol_value(SOME_VAR) = Some(\n\n")
(insert " at file9.rs:12:34\n\n")
;; should not match
Expand All @@ -3736,7 +3737,8 @@ let b = 1;"
(("file5.rs" "12" "34" compilation-info "file5.rs:12:34"))
((like-previous-one "82" back-to-indentation compilation-info "82")
(like-previous-one "132" back-to-indentation compilation-info "132"))
(("src/file7.rs" "12" "34" nil "src/file7.rs:12:34"))
(("src/file7.rs" "12" "34" nil "src/file7.rs:12:34")
("crates/a/src/b.rs" "13" "9" nil "crates/a/src/b.rs:13:9"))
(("src/file8.rs" "159" "5" compilation-info "src/file8.rs:159:5"))
(("file9.rs" "12" "34" compilation-info "file9.rs:12:34")))
(mapcar #'rust-collect-matches
Expand Down
Loading