Skip to content
Permalink
Browse files

std: Delete a by-definition spuriously failing test

This commit deletes the `connect_timeout_unbound` test from the standard
library which, unfortunately, is by definition eventually going to be a
spuriously failing test. There's no way to reserve a port as unbound so
we can rely on ecosystem testing for this feature for now.

Closes #52590
  • Loading branch information...
alexcrichton committed Mar 8, 2019
1 parent b58a006 commit 6465257e5442b489a1d4469d3f613aeb637e3665
Showing with 0 additions and 15 deletions.
  1. +0 −15 src/libstd/net/tcp.rs
@@ -1742,21 +1742,6 @@ mod tests {
})
}

#[test]
fn connect_timeout_unbound() {
// bind and drop a socket to track down a "probably unassigned" port
let socket = TcpListener::bind("127.0.0.1:0").unwrap();
let addr = socket.local_addr().unwrap();
drop(socket);

let timeout = Duration::from_secs(1);
let e = TcpStream::connect_timeout(&addr, timeout).unwrap_err();
assert!(e.kind() == io::ErrorKind::ConnectionRefused ||
e.kind() == io::ErrorKind::TimedOut ||
e.kind() == io::ErrorKind::Other,
"bad error: {} {:?}", e, e.kind());
}

#[test]
fn connect_timeout_valid() {
let listener = TcpListener::bind("127.0.0.1:0").unwrap();

0 comments on commit 6465257

Please sign in to comment.
You can’t perform that action at this time.