Skip to content
Permalink
Browse files

Address comments + Fix tests

  • Loading branch information...
petrochenkov committed May 11, 2019
1 parent 3f064ca commit 83ed781c017632d48746553bdb2bf3d1633d5ca4
Showing with 11 additions and 4 deletions.
  1. +2 −0 src/librustdoc/clean/cfg.rs
  2. +7 −2 src/libsyntax/ast.rs
  3. +2 −2 src/libsyntax/parse/literal.rs
@@ -416,6 +416,8 @@ mod test {

use syntax_pos::DUMMY_SP;
use syntax::ast::*;
use syntax::attr;
use syntax::source_map::dummy_spanned;
use syntax::symbol::Symbol;
use syntax::with_globals;

@@ -1351,12 +1351,17 @@ pub enum StrStyle {
Raw(u16),
}

/// A literal.
/// An AST literal.
#[derive(Clone, RustcEncodable, RustcDecodable, Debug)]
pub struct Lit {
pub node: LitKind,
/// The original literal token as written in source code.
pub token: token::Lit,
/// The original literal suffix as written in source code.
pub suffix: Option<Symbol>,
/// The "semantic" representation of the literal lowered from the original tokens.
/// Strings are unescaped, hexadecimal forms are eliminated, etc.
/// FIXME: Remove this and only create the semantic representation during lowering to HIR.
pub node: LitKind,
pub span: Span,
}

@@ -27,7 +27,7 @@ macro_rules! err {

impl LitKind {
/// Converts literal token with a suffix into a semantic literal.
/// Works speculatively and may return `None` is diagnostic handler is not passed.
/// Works speculatively and may return `None` if diagnostic handler is not passed.
/// If diagnostic handler is passed, always returns `Some`,
/// possibly after reporting non-fatal errors and recovery.
fn from_lit_token(
@@ -166,7 +166,7 @@ impl LitKind {

impl Lit {
/// Converts literal token with a suffix into an AST literal.
/// Works speculatively and may return `None` is diagnostic handler is not passed.
/// Works speculatively and may return `None` if diagnostic handler is not passed.
/// If diagnostic handler is passed, may return `Some`,
/// possibly after reporting non-fatal errors and recovery, or `None` for irrecoverable errors.
crate fn from_token(

0 comments on commit 83ed781

Please sign in to comment.
You can’t perform that action at this time.