Skip to content
Browse files

Hopefully fix rustdoc build

It's super unclear why this broke when we switched to beta but not
previously -- but at least it's hopefully fixed now.
  • Loading branch information
Mark-Simulacrum committed Nov 5, 2019
1 parent 997feac commit 8783766215c28a98eeb0487d865b8afa0ada797c
Showing with 12 additions and 1 deletion.
  1. +12 −1 src/bootstrap/
@@ -886,7 +886,18 @@ impl<'a> Builder<'a> {
// things still build right, please do!
match mode {
Mode::Std => metadata.push_str("std"),
_ => {},
// When we're building rustc tools, they're built with a search path
// that contains things built during the rustc build. For example,
// bitflags is built during the rustc build, and is a dependency of
// rustdoc as well. We're building rustdoc in a different target
// directory, though, which means that Cargo will rebuild the
// dependency. When we go on to build rustdoc, we'll look for
// bitflags, and find two different copies: one built during the
// rustc step and one that we just built. This isn't always a
// problem, somehow -- not really clear why -- but we know that this
// fixes things.
Mode::ToolRustc => metadata.push_str("tool-rustc"),
_ => {}
cargo.env("__CARGO_DEFAULT_LIB_METADATA", &metadata);

0 comments on commit 8783766

Please sign in to comment.
You can’t perform that action at this time.