From 63cfedb73b5ebdc0d46f3fd8e8865306a590f826 Mon Sep 17 00:00:00 2001 From: "Zack M. Davis" Date: Mon, 19 Dec 2016 11:47:37 -0800 Subject: [PATCH] prefer hyphens in test files named after issue numbers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We have a lot of tests with filenames honoring particular issues by number. Typically, these are called issue-${issue_no}.rs (note the hyphen): ``` $ find . -regextype posix-egrep -regex '.*/issue-[0-9]*.rs' | wc 1289 1289 35935 ``` We also had a much smaller number of files that are like this, but don't have a hyphen in between the substring `issue` and the number: ``` $ find . -regextype posix-egrep -regex '.*/issue[0-9]*.rs' ./debuginfo/issue14411.rs ./debuginfo/issue12886.rs ./debuginfo/issue13213.rs ./debuginfo/issue22656.rs ./debuginfo/issue7712.rs ./compile-fail/issue32829.rs ./run-pass/issue24353.rs ./run-pass/issue34796.rs ./run-pass/issue18173.rs ./run-pass/issue22346.rs ./run-pass/auxiliary/issue13507.rs ./run-pass/issue26127.rs ./run-pass/issue22008.rs ./run-pass/issue34569.rs ./run-pass/issue29927.rs ./run-pass/issue36260.rs ``` Some would argue that the inconsistency is æsthetically displeasing, hence this trivial patch. (Note that run-pass/auxiliary/issue13507.rs has an excuse; it's `use`d in run-pass/issue-13507-2.rs; the matter of there being two different compile-fail tests with different name conventions for issue #32829 is also neglected here for the sake of keeping this trivial cleanup patch as trivial as possible for ease of review.) --- src/test/debuginfo/{issue12886.rs => issue-12886.rs} | 0 src/test/debuginfo/{issue13213.rs => issue-13213.rs} | 0 src/test/debuginfo/{issue14411.rs => issue-14411.rs} | 0 src/test/debuginfo/{issue22656.rs => issue-22656.rs} | 0 src/test/debuginfo/{issue7712.rs => issue-7712.rs} | 0 src/test/run-pass/{issue18173.rs => issue-18173.rs} | 0 src/test/run-pass/{issue22008.rs => issue-22008.rs} | 0 src/test/run-pass/{issue22346.rs => issue-22346.rs} | 0 src/test/run-pass/{issue24353.rs => issue-24353.rs} | 0 src/test/run-pass/{issue26127.rs => issue-26127.rs} | 0 src/test/run-pass/{issue29927.rs => issue-29927.rs} | 0 src/test/run-pass/{issue34569.rs => issue-34569.rs} | 0 src/test/run-pass/{issue34796.rs => issue-34796.rs} | 0 src/test/run-pass/{issue36260.rs => issue-36260.rs} | 0 14 files changed, 0 insertions(+), 0 deletions(-) rename src/test/debuginfo/{issue12886.rs => issue-12886.rs} (100%) rename src/test/debuginfo/{issue13213.rs => issue-13213.rs} (100%) rename src/test/debuginfo/{issue14411.rs => issue-14411.rs} (100%) rename src/test/debuginfo/{issue22656.rs => issue-22656.rs} (100%) rename src/test/debuginfo/{issue7712.rs => issue-7712.rs} (100%) rename src/test/run-pass/{issue18173.rs => issue-18173.rs} (100%) rename src/test/run-pass/{issue22008.rs => issue-22008.rs} (100%) rename src/test/run-pass/{issue22346.rs => issue-22346.rs} (100%) rename src/test/run-pass/{issue24353.rs => issue-24353.rs} (100%) rename src/test/run-pass/{issue26127.rs => issue-26127.rs} (100%) rename src/test/run-pass/{issue29927.rs => issue-29927.rs} (100%) rename src/test/run-pass/{issue34569.rs => issue-34569.rs} (100%) rename src/test/run-pass/{issue34796.rs => issue-34796.rs} (100%) rename src/test/run-pass/{issue36260.rs => issue-36260.rs} (100%) diff --git a/src/test/debuginfo/issue12886.rs b/src/test/debuginfo/issue-12886.rs similarity index 100% rename from src/test/debuginfo/issue12886.rs rename to src/test/debuginfo/issue-12886.rs diff --git a/src/test/debuginfo/issue13213.rs b/src/test/debuginfo/issue-13213.rs similarity index 100% rename from src/test/debuginfo/issue13213.rs rename to src/test/debuginfo/issue-13213.rs diff --git a/src/test/debuginfo/issue14411.rs b/src/test/debuginfo/issue-14411.rs similarity index 100% rename from src/test/debuginfo/issue14411.rs rename to src/test/debuginfo/issue-14411.rs diff --git a/src/test/debuginfo/issue22656.rs b/src/test/debuginfo/issue-22656.rs similarity index 100% rename from src/test/debuginfo/issue22656.rs rename to src/test/debuginfo/issue-22656.rs diff --git a/src/test/debuginfo/issue7712.rs b/src/test/debuginfo/issue-7712.rs similarity index 100% rename from src/test/debuginfo/issue7712.rs rename to src/test/debuginfo/issue-7712.rs diff --git a/src/test/run-pass/issue18173.rs b/src/test/run-pass/issue-18173.rs similarity index 100% rename from src/test/run-pass/issue18173.rs rename to src/test/run-pass/issue-18173.rs diff --git a/src/test/run-pass/issue22008.rs b/src/test/run-pass/issue-22008.rs similarity index 100% rename from src/test/run-pass/issue22008.rs rename to src/test/run-pass/issue-22008.rs diff --git a/src/test/run-pass/issue22346.rs b/src/test/run-pass/issue-22346.rs similarity index 100% rename from src/test/run-pass/issue22346.rs rename to src/test/run-pass/issue-22346.rs diff --git a/src/test/run-pass/issue24353.rs b/src/test/run-pass/issue-24353.rs similarity index 100% rename from src/test/run-pass/issue24353.rs rename to src/test/run-pass/issue-24353.rs diff --git a/src/test/run-pass/issue26127.rs b/src/test/run-pass/issue-26127.rs similarity index 100% rename from src/test/run-pass/issue26127.rs rename to src/test/run-pass/issue-26127.rs diff --git a/src/test/run-pass/issue29927.rs b/src/test/run-pass/issue-29927.rs similarity index 100% rename from src/test/run-pass/issue29927.rs rename to src/test/run-pass/issue-29927.rs diff --git a/src/test/run-pass/issue34569.rs b/src/test/run-pass/issue-34569.rs similarity index 100% rename from src/test/run-pass/issue34569.rs rename to src/test/run-pass/issue-34569.rs diff --git a/src/test/run-pass/issue34796.rs b/src/test/run-pass/issue-34796.rs similarity index 100% rename from src/test/run-pass/issue34796.rs rename to src/test/run-pass/issue-34796.rs diff --git a/src/test/run-pass/issue36260.rs b/src/test/run-pass/issue-36260.rs similarity index 100% rename from src/test/run-pass/issue36260.rs rename to src/test/run-pass/issue-36260.rs