From 9372c4f6acddce4ec3077a2f8e170549f35b6282 Mon Sep 17 00:00:00 2001 From: Nick Cameron Date: Thu, 25 Aug 2022 07:42:07 +0100 Subject: [PATCH] error::Error: remove some comments Signed-off-by: Nick Cameron --- library/core/src/error.rs | 15 --------------- library/std/src/error.rs | 15 --------------- 2 files changed, 30 deletions(-) diff --git a/library/core/src/error.rs b/library/core/src/error.rs index a4ed2868c9109..4a8efe15e596b 100644 --- a/library/core/src/error.rs +++ b/library/core/src/error.rs @@ -1,17 +1,6 @@ #![doc = include_str!("error.md")] #![unstable(feature = "error_in_core", issue = "none")] -// A note about crates and the facade: -// -// Originally, the `Error` trait was defined in libcore, and the impls -// were scattered about. However, coherence objected to this -// arrangement, because to create the blanket impls for `Box` required -// knowing that `&str: !Error`, and we have no means to deal with that -// sort of conflict just now. Therefore, for the time being, we have -// moved the `Error` trait into libstd. As we evolve a sol'n to the -// coherence challenge (e.g., specialization, neg impls, etc) we can -// reconsider what crate these items belong in. - #[cfg(test)] mod tests; @@ -417,10 +406,6 @@ impl dyn Error { // because that means the method can't be called on trait objects (we'd also need the // 'static bound, but that isn't allowed because methods with bounds on Self other than // Sized are not object-safe). Requiring an Unsize bound is not backwards compatible. - // - // Two possible solutions are to start the iterator at self.source() instead of self (see - // discussion on the tracking issue), or to wait for dyn* to exist (which would then permit - // the coercion). Source { current: Some(self) } } diff --git a/library/std/src/error.rs b/library/std/src/error.rs index f36765c07078c..e45059595362f 100644 --- a/library/std/src/error.rs +++ b/library/std/src/error.rs @@ -1,17 +1,6 @@ #![doc = include_str!("../../core/src/error.md")] #![stable(feature = "rust1", since = "1.0.0")] -// A note about crates and the facade: -// -// Originally, the `Error` trait was defined in libcore, and the impls -// were scattered about. However, coherence objected to this -// arrangement, because to create the blanket impls for `Box` required -// knowing that `&str: !Error`, and we have no means to deal with that -// sort of conflict just now. Therefore, for the time being, we have -// moved the `Error` trait into libstd. As we evolve a sol'n to the -// coherence challenge (e.g., specialization, neg impls, etc) we can -// reconsider what crate these items belong in. - #[cfg(test)] mod tests; @@ -996,10 +985,6 @@ impl dyn Error { // because that means the method can't be called on trait objects (we'd also need the // 'static bound, but that isn't allowed because methods with bounds on Self other than // Sized are not object-safe). Requiring an Unsize bound is not backwards compatible. - // - // Two possible solutions are to start the iterator at self.source() instead of self (see - // discussion on the tracking issue), or to wait for dyn* to exist (which would then permit - // the coercion). Sources { current: Some(self) } }