Cache evaluations even when proof tree is being built

Author: compiler-errors

compiler/rustc_type_ir/src/search_graph/global_cache.rs

@@ -57,14 +57,14 @@ impl<X: Cx> GlobalCache<X> {
             let with_overflow = WithOverflow { nested_goals, result };
             let prev = entry.with_overflow.insert(required_depth, with_overflow);
             if let Some(prev) = &prev {
-                assert!(cx.evaluation_is_concurrent());
-                assert_eq!(cx.get_tracked(&prev.result), origin_result);
+                let prev_result = cx.get_tracked(&prev.result);
+                assert_eq!(prev_result, origin_result);
             }
         } else {
             let prev = entry.success.replace(Success { required_depth, nested_goals, result });
             if let Some(prev) = &prev {
-                assert!(cx.evaluation_is_concurrent());
-                assert_eq!(cx.get_tracked(&prev.result), origin_result);
+                let prev_result = cx.get_tracked(&prev.result);
+                assert_eq!(prev_result, origin_result);
             }
         }
     }

compiler/rustc_type_ir/src/search_graph/mod.rs

@@ -652,7 +652,7 @@ impl<D: Delegate<Cx = X>, X: Cx> SearchGraph<D> {
                 // Do not try to move a goal into the cache again if we're testing
                 // the global cache.
                 assert_eq!(result, expected, "input={input:?}");
-            } else if D::inspect_is_noop(inspect) {
+            } else {
                 self.insert_global_cache(cx, final_entry, result, dep_node)
             }
         } else if D::ENABLE_PROVISIONAL_CACHE {