Skip to content

Commit

Permalink
Make clear that status quo ≠ guarantee
Browse files Browse the repository at this point in the history
  • Loading branch information
petertodd committed May 19, 2019
1 parent aa1db24 commit a91ad60
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/test/run-pass/union/union-nonzero.rs
Expand Up @@ -6,8 +6,9 @@
// For example, if a union `U` can contain both a `&T` and a `*const T`, there's definitely no
// bit-value that an `Option<U>` could reuse as `None`; this test makes sure that isn't done.
//
// Secondly, this tests the status quo to not apply such optimizations to types containing unions
// even if they're theoretically possible. (discussion: https://github.com/rust-lang/rust/issues/36394)
// Secondly, this tests the status quo (not a guarantee; subject to change!) to not apply such
// optimizations to types containing unions even if they're theoretically possible. (discussion:
// https://github.com/rust-lang/rust/issues/36394)
//
// Notably this nails down part of the behavior that `MaybeUninit` assumes: that a
// `Option<MaybeUninit<&u8>>` does not take advantage of non-zero optimization, and thus is a safe
Expand Down

0 comments on commit a91ad60

Please sign in to comment.