Skip to content
Permalink
Tree: fd8e23c6b2
Commits on May 24, 2019
  1. Auto merge of #61105 - Centril:rollup-t9lemjf, r=Centril

    bors committed May 24, 2019
    Rollup of 6 pull requests
    
    Successful merges:
    
     - #59545 (Use arenas to avoid Lrc in queries #2)
     - #61054 (Suggest dereferencing on assignment to mutable borrow)
     - #61056 (tweak discriminant on non-nullary enum diagnostic)
     - #61082 (fix dangling reference in Vec::append)
     - #61086 (Box::into_unique: do the reborrow-to-raw *after* destroying the Box)
     - #61098 (Fix overflowing literal lint in loops)
    
    Failed merges:
    
    r? @ghost
Commits on May 23, 2019
  1. Rollup merge of #61098 - varkor:fix-overflowing-literal-in-loop, r=es…

    Centril committed May 23, 2019
    …tebank
    
    Fix overflowing literal lint in loops
    
    Fixes #60459.
    
    r? @estebank
  2. Rollup merge of #61086 - RalfJung:box, r=alexcrichton

    Centril committed May 23, 2019
    Box::into_unique: do the reborrow-to-raw *after* destroying the Box
    
    Currently we first "reborrow" the box to a raw pointer, and then `forget` it. When tracking raw pointers more strictly (something I am experimenting with locally in Miri), the "use" induced by passing the box to `forget` invalidates the previously created raw pointer.
    
    So adjust my hack from #58429 to reorder the two operations.
  3. Rollup merge of #61082 - RalfJung:vec, r=alexcrichton

    Centril committed May 23, 2019
    fix dangling reference in Vec::append
    
    Turns out I forgot to enable Miri again for the Vec tests. And there was a dangling reference hiding in there!  `get_unchecked_mut` is UB to call on an empty vector (there is no memory to get a reference to), and yet this code did it.
  4. Rollup merge of #61056 - euclio:custom-discriminant-error, r=estebank

    Centril committed May 23, 2019
    tweak discriminant on non-nullary enum diagnostic
    
    Adds notes pointing at the non-nullary variants, and uses "custom
    discriminant" language to be consistent with the Reference.
    
    Fixes #61039.
    
    r? @estebank
  5. Rollup merge of #61054 - estebank:mut-ref-reassign, r=zackmdavis

    Centril committed May 23, 2019
    Suggest dereferencing on assignment to mutable borrow
    
    Fix #33570
  6. Rollup merge of #59545 - Zoxc:the-arena-3, r=eddyb,michaelwoerister

    Centril committed May 23, 2019
    Use arenas to avoid Lrc in queries #2
    
    The `Remove subtle Default impl for Value` makes the compilation stop due earlier due to cycle errors, since there's no longer a default value to continue the compilation with.
    
    Based on #59540.
  7. Auto merge of #60970 - MaulingMonkey:pr-compiletest-cdb-support, r=al…

    bors committed May 23, 2019
    …excrichton
    
    Add basic CDB support to debuginfo compiletest s, to help catch `*.natvis` regressions, like those fixed in #60687.
    
    First draft, feedback welcome.
    
    Several Microsoft debuggers (VS, VS Code, WinDbg, CDB, ...) consume the `*.natvis` files we embed into rust `*.pdb` files.  While this only tests CDB, that test coverage should help for all of them.
    
    # Changes
    
    ## src\bootstrap
      - test.rs:  Run CDB debuginfo tests on MSVC targets
    
    ## src\test\debuginfo
      - issue-13213.rs:  CDB has trouble with this, skip for now (newly discovered regression?)
      - pretty-std.rs:  Was ignored, re-enable for CDB only to start with, add CDB tests.
      - should-fail.rs:  Add CDB tests.
    
    ## src\tools\compiletest:
      - Added "-cdb" option
      - Added Mode::DebugInfoCdb ("debuginfo-cdb")
      - Added run_debuginfo_cdb_test[_no_opt]
      - Renamed Mode::DebugInfoBoth -> DebugInfoGdbLldb ("debuginfo-gdb+lldb") since it's no longer clear what "Both" means.
      - Find CDB at the default Win10 SDK install path "C:\Program Files (x86)\Windows Kits\10\Debugger\\*\cdb.exe"
      - Ignore CDB tests if CDB not found.
    
    # Issues
    
      - `compute_stamp_hash`: not sure if there's any point in hashing `%ProgramFiles(x86)%`
      - `OsString` lacks any `*.natvis` entries (would be nice to add in a followup changelist)
      - DSTs (array/string slices) which work in VS & VS Code fail in CDB.
      - I've avoided `Mode::DebugInfoAll` as 3 debuggers leads to pow(2,3)=8 possible combinations.
    
    # Reference
    
    CDB is not part of the base Visual Studio install, but can be added via the Windows 10 SDK:
      https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk
    Installing just "Debugging Tools for Windows" is sufficient.
    
    CDB appears to already be installed on appveyor CI, where this changelist can find it, based on it's use here:
      https://github.com/rust-lang/rust/blob/0ffc57311030a1930edfa721fe57d0000a063af4/appveyor.yml#L227
    
    CDB commands and command line reference:
      https://docs.microsoft.com/en-us/windows-hardware/drivers/debugger/debugger-reference
  8. Add test for denying overflowing literal in loop

    varkor committed May 23, 2019
  9. Update unreachable loop patterns test

    varkor committed May 23, 2019
  10. Add regression test for negative case

    estebank committed May 23, 2019
  11. Update crate_variances and inferred_outlives_crate

    Zoxc committed May 20, 2019
  12. Update visible_parent_map

    Zoxc committed Dec 1, 2018
  13. Update get_lib_features, defined_lib_features, get_lang_items, define…

    Zoxc committed Dec 1, 2018
    …d_lang_items, missing_lang_items, postorder_cnums and maybe_unused_extern_crates
  14. Update in_scope_traits_map

    Zoxc committed Dec 1, 2018
  15. Update privacy_access_levels

    Zoxc committed Dec 1, 2018
  16. Update all_traits

    Zoxc committed Nov 30, 2018
  17. Update lint_levels

    Zoxc committed Nov 30, 2018
  18. Update Cargo.lock

    Zoxc committed May 19, 2019
  19. Make ArenaField private

    Zoxc committed May 19, 2019
  20. Add a comment for arena_types!

    Zoxc committed May 19, 2019
  21. Optimize alloc_from_iter

    Zoxc committed Apr 23, 2019
  22. Update used_trait_imports

    Zoxc committed Nov 30, 2018
  23. Update item_children

    Zoxc committed Nov 30, 2018
  24. Update resolve_lifetimes, named_region_map, is_late_bound_map and obj…

    Zoxc committed Nov 30, 2018
    …ect_lifetime_defaults_map
Older
You can’t perform that action at this time.