Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make empty enums non-affine #10278

Closed
nikomatsakis opened this Issue Nov 5, 2013 · 1 comment

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@nikomatsakis
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Nov 5, 2013

Today empty enums are affine. I can't think of a reason for this to be. There is this comment in the source that says: "we somewhat arbitrary declare that empty enums are non-copyable". For all I know I wrote it. Anyway, in my rewrite of type contents, I forgot to reproduce this arbitrary rule, and I'm not inclined to add it back unless someone objects.
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nikomatsakis commented Nov 5, 2013

cc #10157 #10158

@nikomatsakis nikomatsakis referenced this issue Nov 5, 2013

Merged

Issue 10157 type contents refactor #10289

bors added a commit that referenced this issue Nov 6, 2013

@bors
auto merge of #10289 : nikomatsakis/rust/issue-10157-TypeContents-ref… 
…actor, r=pcwalton

See #10157. This compiles now.

Fixes #10278.
fdc830d

@nikomatsakis nikomatsakis closed this in f3191a4 Nov 6, 2013

willingc added a commit to willingc/rust that referenced this issue Nov 12, 2013

@bors @willingc
auto merge of rust-lang#10289 : nikomatsakis/rust/issue-10157-TypeCon… 
…tents-refactor, r=pcwalton

See rust-lang#10157. This compiles now.

Fixes rust-lang#10278.

Fixed xfail for nbody shootout benchmark by correcting command line parse.
Cleaned up unneeded imports and type changes to resolve compiler warnings.
25c1ee0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.