Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/debug-info: filename extension matters on windows #13256

Closed
klutzy opened this Issue Apr 2, 2014 · 7 comments

Comments

Projects
None yet
5 participants
@klutzy
Copy link
Contributor

klutzy commented Apr 2, 2014

make check-<stage>-debuginfo compiles some-test.rs into some-test.<stage>-<target>, which is actually some-test.<stage>-<target>.exe on windows.

This causes test failures on windows:

$ gdb ./basic-types-globals-metadata.stage2-i686-w64-mingw32.exe
...

(gdb) whatis 'basic-types-globals-metadata::B'  <- expected to work in test
No symbol "basic-types-globals-metadata::B" in current context.

(gdb) whatis 'basic-types-globals-metadata.stage2-i686-w64-mingw32::B'
type = bool

Relevant tests:

    [debug-info] debug-info/basic-types-globals-metadata.rs
    [debug-info] debug-info/basic-types-globals.rs
    [debug-info] debug-info/basic-types-mut-globals.rs
    [debug-info] debug-info/c-style-enum.rs
    [debug-info] debug-info/lexical-scopes-in-block-expression.rs
    [debug-info] debug-info/simple-struct.rs
    [debug-info] debug-info/simple-tuple.rs
    [debug-info] debug-info/vec-slices.rs
    [debug-info] debug-info/vec.rs

@jdm jdm added the A-debuginfo label Apr 2, 2014

@michaelwoerister

This comment has been minimized.

Copy link
Contributor

michaelwoerister commented Apr 23, 2014

Thanks for the report, I'll look into it.

@brson brson added the A-windows label Aug 12, 2014

@brson brson referenced this issue Aug 12, 2014

Closed

Windows metabug #16459

28 of 33 tasks complete
@michaelwoerister

This comment has been minimized.

Copy link
Contributor

michaelwoerister commented Oct 30, 2014

I can't reproduce this (anymore?). This seems to have been fixed in the meanwhile. Debuginfo generation picks up the correct crate name also on Windows.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Oct 30, 2014

Closing for now, but of course feel free to reopen if it reproduces still!

@michaelwoerister

This comment has been minimized.

Copy link
Contributor

michaelwoerister commented Oct 30, 2014

@alexcrichton Well, I wanted to re-enable the tests in question before closing the issue, which in turn I wanted to do after the current Windows-related PR had landed. Would you mind if I just update the open PR to enable the tests? The queue is quite long at the moment.

@alexcrichton alexcrichton reopened this Oct 30, 2014

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Oct 30, 2014

Aha, of course!

@michaelwoerister

This comment has been minimized.

Copy link
Contributor

michaelwoerister commented Oct 30, 2014

Done. Re-approve please: #18422

@klutzy

This comment has been minimized.

Copy link
Contributor Author

klutzy commented Nov 1, 2014

#18422 passed on buildbot, and check-stage2-debuginfo-gdb passed on my machine (win64 + msys2 + gdb 7.8). Woohoo!

@klutzy klutzy closed this Nov 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.