Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement associated items #17307
Comments
alexcrichton
added
I-nominated
B-RFC-approved
labels
Sep 16, 2014
This comment has been minimized.
This comment has been minimized.
|
there is debate about whether this contains P-backcompat-lang issues for 1.0, or if the 1.0 issues are solely P-backcompat-libs. Leaving as I-nominated so that people can take a week teasing apart the sub-issues that stem from the RFC. |
pnkfelix
self-assigned this
Sep 25, 2014
This comment has been minimized.
This comment has been minimized.
|
leaving I-nominated for anohter week again! assigning to myself to spawn off subissues. |
nikomatsakis
referenced this issue
Oct 1, 2014
Merged
Implement multidispatch and conditional dispatch. #17669
This comment has been minimized.
This comment has been minimized.
|
punting for another week... |
This comment has been minimized.
This comment has been minimized.
|
@pnkfelix Want to coordinate this work this week? I want to do an evaluation of how much of associated items has landed in terms of what we need for the libraries, and that could help inform the division into subissues/nominations. Let me know. |
This comment has been minimized.
This comment has been minimized.
|
@aturon sure, happy to coordinate. I'm going to actually look at it now; I will either open subissues directly, or, if I do not feel comfortable doing so, then I'll email you with my findings. |
This was referenced Oct 6, 2014
This comment has been minimized.
This comment has been minimized.
|
Okay I think I've opened all the subbugs I can think of, and my spreadsheet (google doc) at least represents a hackish sketch of what might need to do be done (though I did not look at Anyway, if this sits idle until the next triage meeting, my official recommendation is that we nominate one or more of the tickets that I opened that point to this ticket, and then we remove the nomination from this ticket (since it is a metabug, quite literally now). |
pnkfelix
added
the
metabug
label
Oct 6, 2014
This comment has been minimized.
This comment has been minimized.
|
@pnkfelix Thanks for doing this! One further issue: right now, associated types are (largely) working, and multidispatch is on the way. But associated constants, lifetimes and inherent items are not implemented. We may want to break those into further issues, so we can triage each part separately. For example, I don't think associated constants need to be 1.0 (we can work around it reasonably in the libraries), but associated lifetimes probably are (because we intend not to allow lifetimes as "input" parameters on a trait, but you need some way to talk about them.) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@pnkfelix The new issues appear to focus on rolling out the features for the libraries, but don't mention actually implementing them :-) but probably they can be triaged together? |
This comment has been minimized.
This comment has been minimized.
|
@aturon oh yes I see; you are right, we still need issues for the language changes themselves. But the triage can focus on the library back-compat and stabilization issues, right? That was driving my focus |
This comment has been minimized.
This comment has been minimized.
|
@pnkfelix Yep, sounds fine -- and honestly, those issues can probably cover both the implementation and the library work, since the two go hand-in-hand. |
This was referenced Oct 7, 2014
This comment has been minimized.
This comment has been minimized.
|
removing i-nominated tag. yay |
pnkfelix
removed
the
I-nominated
label
Oct 9, 2014
bors
added a commit
that referenced
this issue
Oct 10, 2014
This comment has been minimized.
This comment has been minimized.
|
I have been working on this a little. I am going to repurpose this issue to mean specifically bounds that are not builtin types, since builtin type bounds are covered by #17921 |
cmr
referenced this issue
Nov 3, 2014
Closed
Make Device completely self-contained with associated types #416
japaric
referenced this issue
Nov 4, 2014
Closed
rustdoc panics when dealing with associated types #18594
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Should there be a work item for defaults for associated types? (I think this is in the RFC) |
This comment has been minimized.
This comment has been minimized.
|
@nick29581 I added it to the list, but didn't create an issue yet. |
huonw
added
the
A-associated-items
label
Nov 20, 2014
This comment has been minimized.
This comment has been minimized.
|
#19129 (ICE implementing trait with generic parameter and associated type) should be on this list. Unfortunately it prevents the fix for #17388 from really helping much; even though some of the previously affected traits now compile, you can't actually implement any functions associated with those traits. |
This comment has been minimized.
This comment has been minimized.
|
@quantheory Added, thanks! |
This comment has been minimized.
This comment has been minimized.
|
Adding |
This comment has been minimized.
This comment has been minimized.
|
Meta-note: the top-level comment includes all bugs listed so far that have not yet been fixed. |
nikomatsakis
unassigned
pnkfelix
Jan 3, 2015
This comment has been minimized.
This comment has been minimized.
rrichardson
commented
Jan 4, 2015
|
Found a possible bug wrt to traits which have types which are Deref: #20502 |
This comment has been minimized.
This comment has been minimized.
alexcrichton
referenced this issue
Jan 6, 2015
Closed
Associated types may not all be normalized #20604
This comment has been minimized.
This comment has been minimized.
|
cc me |
This comment has been minimized.
This comment has been minimized.
|
I updated the list in this issue. A lot of items are done now! |
alexcrichton
added
the
T-lang
label
Aug 11, 2015
This comment has been minimized.
This comment has been minimized.
|
Has #8995 been lost from this list somehow? |
This comment has been minimized.
This comment has been minimized.
lilianmoraru
referenced this issue
Jan 23, 2016
Closed
Calculator example: thread panicked while processing panic. Illegal instruction #11
This comment has been minimized.
This comment has been minimized.
|
This has basically all long since been implemented, so closing. |
alexcrichton
closed this
Feb 18, 2016
This comment has been minimized.
This comment has been minimized.
dashed
commented
Sep 1, 2016
|
This isn't implemented yet: #8995 |
malbarbo
added a commit
to malbarbo/fera
that referenced
this issue
Nov 10, 2017
This comment has been minimized.
This comment has been minimized.
|
What happened to associated const bounds as in the following? An omission perhaps? trait Foo {
const Bar: usize;
}
fn baz<T: Foo<Bar = 1>>() {} |
alexcrichton commentedSep 16, 2014
Tracking issue for rust-lang/rfcs#195
This meta-bug contains links to the most significant tasks remaining for associated items. For a comprehensive listing of bugs, please search using the A-associated-items label.
Post 1.0 Tasks
Completed Tasks
Trait<Out=Type>syntax (#18432)T::Typesyntax (#18433)Declined tasks
Permit unqualified references to associated types of the trait within the trait definition (#18764)Update library code for associated lifetimes (see Issue #17828),