Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement where clauses #17657
Comments
brson
added
C-enhancement
I-nominated
labels
Sep 30, 2014
This comment has been minimized.
This comment has been minimized.
|
P-backcompat-libs, but not 1.0. |
pnkfelix
added
P-backcompat-libs
and removed
I-nominated
labels
Oct 2, 2014
This comment has been minimized.
This comment has been minimized.
|
I've been working on this somewhat in the background. The patch is somewhat more involved than I imagined initially because where clauses are more powerful than I initially imagined -- in particular, there are lots of bits of code that assume that there is an intrinsic set of bounds associated with a specific type parameter, whereas where clauses make those things scope dependent. We've been steadily removed them and by now all the deep connections are almost entirely eradicated (@pcwalton's work in #17864 is, I think, the last bit). In my branch, I was removing all the lists of bounds from type parameters and adding in a list of predicates instead. It occurred to me today that it might also be possible to phase support for this in faster by doing it in two stages: first, leaving the code as is but adding a generalized list of predicates, and then removing the bounds lists. I'm not sure which is better. |
This comment has been minimized.
This comment has been minimized.
|
@nikomatsakis I'm looking into this after our conversation this morning. Let me know if there are any other tracking issues I should be following. I am going to go dig up your branch and work on it during the afternoon session. |
nikomatsakis
referenced this issue
Dec 19, 2014
Merged
Implement parsing and conversion of generalized where clauses #20002
This comment has been minimized.
This comment has been minimized.
|
@nikomatsakis would it be possible to update the check list at some point? would be good to check at glance what remains. It is fine if it happens after #20020 lands. |
jroesch
referenced this issue
Jan 2, 2015
Closed
`where` clause not honored in trait `impl` body #20414
This comment has been minimized.
This comment has been minimized.
|
Nominating for removal from P-backcompat-libs; enough has landed for us to already roll this out. |
aturon
added
the
I-nominated
label
Jan 8, 2015
This comment has been minimized.
This comment has been minimized.
|
removing from P-backcompat-libs (since the back compat stuff is done). P-high. |
brson commentedSep 30, 2014
•
edited by Mark-Simulacrum
Tracking rust-lang/rfcs#135.
Task list: