Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upExpand macros in attributes #18849
Comments
huonw
added
the
A-syntaxext
label
Nov 10, 2014
This comment has been minimized.
This comment has been minimized.
|
@eddyb on IRC:
|
SimonSapin
referenced this issue
Nov 10, 2014
Closed
include! macro fails if included file has top-level inner attributes #18810
This comment has been minimized.
This comment has been minimized.
|
This would be quite convenient. |
This comment has been minimized.
This comment has been minimized.
|
@SimonSapin you quoted me out of context, you get to write the RFC for it. |
This comment has been minimized.
This comment has been minimized.
|
Is it possible to do this backward-compatibly after 1.0? |
huonw
referenced this issue
Nov 18, 2015
Closed
`include!` is a smell and should be made obsolete for code-generating cargo packages #21147
huonw
added
the
T-lang
label
Nov 18, 2015
This comment has been minimized.
This comment has been minimized.
Should be fine, yes. |
This comment has been minimized.
This comment has been minimized.
SirVer
commented
Dec 8, 2016
|
Future searchers: I stumbled on this issue as I created a generated module in |
This comment has been minimized.
This comment has been minimized.
|
Closing. If someone wants to pursue this, please follow the RFC process here https://github.com/rust-lang/rfcs#before-creating-an-rfc; the change is major enough to warrant this. |
Mark-Simulacrum
closed this
Jun 25, 2017
This comment has been minimized.
This comment has been minimized.
|
Is anyone working on this, or is there an RFC in the pipeline? If not, I'm willing to start work on one. |
This comment has been minimized.
This comment has been minimized.
|
To my knowledge no one is working on this, but asking on internals.rust-lang.org is likely a good start. |
This comment has been minimized.
This comment has been minimized.
|
@pierzchalski Have you gotten a chance to start an RFC for this? |
SimonSapin commentedNov 10, 2014
Something like this would be nice for code generation in Cargo. (See rust-lang/cargo#824.)
But it currently doesn’t parse:
Can we make this work? I have a hack in #18810 (comment) to work around it, but it’s ugly.
CC @alexcrichton @eddyb