Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stability story of compiler flags #19051

Closed
huonw opened this Issue Nov 17, 2014 · 12 comments

Comments

Assignees

@alexcrichton alexcrichton

Labels
P-medium
Projects
None yet
Milestone
No milestone
9 participants
@huonw @pnkfelix @aturon @kmcallister @cmr @rprichard @brson @alexcrichton @steveklabnik
@huonw
Copy link
Member

huonw commented Nov 17, 2014

There's a pile of weird and wonderful flags for rustc and we should have some conscious story about them and their stability, even if it's just "they're all unstable".

@huonw huonw added A-tools I-nominated labels Nov 17, 2014

@pnkfelix

This comment has been minimized.

Sign in to view
Copy link
Member

pnkfelix commented Nov 20, 2014

P-backcompat-libs, 1.0.

@pnkfelix pnkfelix added P-backcompat-libs and removed I-nominated labels Nov 20, 2014

@pnkfelix pnkfelix added this to the 1.0 milestone Nov 20, 2014

@aturon aturon referenced this issue Nov 24, 2014

Closed

Stabilization metabug: 1.0-alpha #19260

140 of 142 tasks complete

@alexcrichton alexcrichton referenced this issue Dec 16, 2014

Merged

rustc: Start "stabilizing" some flags #19900

bors added a commit that referenced this issue Dec 20, 2014

@bors
auto merge of #19900 : alexcrichton/rust/compiler-flags, r=cmr 
This commit shuffles around some CLI flags of the compiler to some more stable
locations with some renamings. The changes made were:

* The `-v` flag has been repurposes as the "verbose" flag. The version flag has
  been renamed to `-V`.
* The `-h` screen has been split into two parts. Most top-level options (not
  all) show with `-h`, and the remaining options (generally obscure) can be
  shown with `--help -v` which is a "verbose help screen"
* The `-V` flag (version flag now) has lost its argument as it is now requested
  with `rustc -vV` "verbose version".
* The `--emit` option has had its `ir` and `bc` variants renamed to `llvm-ir`
  and `llvm-bc` to emphasize that they are LLVM's IR/bytecode.
* The `--emit` option has grown a new variant, `dep-info`, which subsumes the
  `--dep-info` CLI argument. The `--dep-info` flag is now deprecated.
* The `--parse-only`, `--no-trans`, `--no-analysis`, and `--pretty` flags have
  moved behind the `-Z` family of flags.
* The `--debuginfo` and `--opt-level` flags were moved behind the top-level `-C`
  flag.
* The `--print-file-name` and `--print-crate-name` flags were moved behind one
  global `--print` flag which now accepts one of `crate-name`, `file-names`, or
  `sysroot`. This global `--print` flag is intended to serve as a mechanism for
  learning various metadata about the compiler itself.
* The top-level `--pretty` flag was moved to a number of `-Z` options.

No warnings are currently enabled to allow tools like Cargo to have time to
migrate to the new flags before spraying warnings to all users.

cc #19051
1225ea6

bors added a commit that referenced this issue Dec 20, 2014

@bors
auto merge of #19900 : alexcrichton/rust/compiler-flags, r=cmr 
This commit shuffles around some CLI flags of the compiler to some more stable
locations with some renamings. The changes made were:

* The `-v` flag has been repurposes as the "verbose" flag. The version flag has
  been renamed to `-V`.
* The `-h` screen has been split into two parts. Most top-level options (not
  all) show with `-h`, and the remaining options (generally obscure) can be
  shown with `--help -v` which is a "verbose help screen"
* The `-V` flag (version flag now) has lost its argument as it is now requested
  with `rustc -vV` "verbose version".
* The `--emit` option has had its `ir` and `bc` variants renamed to `llvm-ir`
  and `llvm-bc` to emphasize that they are LLVM's IR/bytecode.
* The `--emit` option has grown a new variant, `dep-info`, which subsumes the
  `--dep-info` CLI argument. The `--dep-info` flag is now deprecated.
* The `--parse-only`, `--no-trans`, `--no-analysis`, and `--pretty` flags have
  moved behind the `-Z` family of flags.
* The `--debuginfo` and `--opt-level` flags were moved behind the top-level `-C`
  flag.
* The `--print-file-name` and `--print-crate-name` flags were moved behind one
  global `--print` flag which now accepts one of `crate-name`, `file-names`, or
  `sysroot`. This global `--print` flag is intended to serve as a mechanism for
  learning various metadata about the compiler itself.
* The top-level `--pretty` flag was moved to a number of `-Z` options.

No warnings are currently enabled to allow tools like Cargo to have time to
migrate to the new flags before spraying warnings to all users.

cc #19051
Loading status checks…
f8f2c7a

@pnkfelix pnkfelix referenced this issue Dec 22, 2014

Merged

Everybody loops pprint; -Z unstable-options #19964

@aturon aturon referenced this issue Jan 8, 2015

Closed

Stabilization for 1.0-alpha2 #20761

29 of 38 tasks complete
@aturon

This comment has been minimized.

Sign in to view
Copy link
Member

aturon commented Jan 8, 2015

Nominating: we need to consider whether this is essential for beta.

@aturon aturon added the I-nominated label Jan 8, 2015

@pnkfelix

This comment has been minimized.

Sign in to view
Copy link
Member

pnkfelix commented Jan 8, 2015

Assigning 1.0-beta milestone.

@pnkfelix pnkfelix modified the milestones: 1.0 beta, 1.0 Jan 8, 2015

@pnkfelix pnkfelix removed the I-nominated label Jan 8, 2015

@kmcallister

This comment has been minimized.

Sign in to view
Copy link
Contributor

kmcallister commented Jan 19, 2015

cc me

kmcallister added a commit to kmcallister/rust that referenced this issue Jan 19, 2015

@kmcallister
Add rustc --drawing to use Unicode line drawing characters for span o… 
…utput

I bet we can find other uses for these sorts of characters in clarifying type
errors, etc.

This is marked as a "stable" flag for consistency with --color. However we
should reconsider both of them as part of rust-lang#19051. For these features to be
conveniently available with Cargo, we may want to use environment variables or
a config file.
1b79e45

kmcallister added a commit to kmcallister/rust that referenced this issue Jan 19, 2015

@kmcallister
Add rustc --drawing to use Unicode line drawing characters for span o… 
…utput

I bet we can find other uses for these sorts of characters in clarifying type
errors, etc.

This is marked as a "stable" flag for consistency with --color. However we
should reconsider both of them as part of rust-lang#19051. For these features to be
conveniently available with Cargo, we may want to use environment variables or
a config file.
f250110

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jan 20, 2015

@alexcrichton
rustc: Remove deprecated flags 
This commit removes a number of deprecated flags from the compiler:

* opt-level => -C opt-level
* debuginfo => -C debuginfo
* print-crate-name => --print crate-name
* print-file-name => --print file-names
* no-trans => -Z no-trans
* no-analysis => -Z no-analysis
* parse-only => -Z parse-only
* dep-info => --emit dep-info

This commit also moves the --pretty flag behind `-Z unstable-options` as the
pretty printer will likely not be stable for 1.0

cc rust-lang#19051
953f294
@pnkfelix

This comment has been minimized.

Sign in to view
Copy link
Member

pnkfelix commented Feb 12, 2015

assigning to @alexcrichton (but I can take it from you if need be)

@pnkfelix pnkfelix assigned alexcrichton Feb 12, 2015

@aturon aturon referenced this issue Feb 18, 2015

Closed

Stabilization for 1.0-beta #22500

75 of 91 tasks complete
@pnkfelix

This comment has been minimized.

Sign in to view
Copy link
Member

pnkfelix commented Mar 26, 2015

the top-level has been cleaned up, but the sublevels of -C etc have not been addressed.
@pnkfelix

This comment has been minimized.

Sign in to view
Copy link
Member

pnkfelix commented Mar 26, 2015

reclassifying as 1.0. (not a beta-blocker at this point.)

@pnkfelix pnkfelix modified the milestones: 1.0, 1.0 beta Mar 26, 2015

@cmr

This comment has been minimized.

Sign in to view
Copy link
Member

cmr commented Mar 26, 2015

My inclination is to not make any hard promises about rustc compat, but try really hard not to break any flag that isn't behind -h or -Z unstable-options.
@rprichard

This comment has been minimized.

Sign in to view
Copy link
Contributor

rprichard commented Apr 1, 2015

The --cfg option's argument is lax (#23301), and escaping a string literal is awkward (e.g. --cfg 'feature="mysql"' vs --cfg feature=mysql). Is this something to fix for 1.0?
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Apr 23, 2015

@rprichard I think #23301 can be done as a bug fix later.
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Apr 23, 2015

Re-triaging as P-medium. There doesn't seem much momentum to make any drastic improvements here and the bar to getting into 1.0 is pretty high.

@brson brson added the P-medium label Apr 23, 2015

@brson brson removed this from the 1.0 milestone Apr 23, 2015

@brson brson removed the P-backcompat-libs label Apr 24, 2015

@bstrie bstrie referenced this issue Apr 30, 2015

Closed

Forbid the -Z compiler flags from being used in beta and stable releases #24971

LeoTestard added a commit to LeoTestard/rust that referenced this issue Oct 7, 2015

@kmcallister @LeoTestard
Add rustc --drawing to use Unicode line drawing characters for span o… 
…utput

I bet we can find other uses for these sorts of characters in clarifying type
errors, etc.

This is marked as a "stable" flag for consistency with --color. However we
should reconsider both of them as part of rust-lang#19051. For these features to be
conveniently available with Cargo, we may want to use environment variables or
a config file.
2ef0f2b

LeoTestard added a commit to LeoTestard/rust that referenced this issue Oct 7, 2015

@kmcallister @LeoTestard
Add rustc --drawing to use Unicode line drawing characters for span o… 
…utput

I bet we can find other uses for these sorts of characters in clarifying type
errors, etc.

This is marked as a "stable" flag for consistency with --color. However we
should reconsider both of them as part of rust-lang#19051. For these features to be
conveniently available with Cargo, we may want to use environment variables or
a config file.
c6ebf29

LeoTestard added a commit to LeoTestard/rust that referenced this issue Oct 7, 2015

@kmcallister @LeoTestard
Add rustc --drawing to use Unicode line drawing characters for span o… 
…utput

I bet we can find other uses for these sorts of characters in clarifying type
errors, etc.

This is marked as a "stable" flag for consistency with --color. However we
should reconsider both of them as part of rust-lang#19051. For these features to be
conveniently available with Cargo, we may want to use environment variables or
a config file.
6b4c86a

LeoTestard added a commit to LeoTestard/rust that referenced this issue Oct 7, 2015

@kmcallister @LeoTestard
Add rustc --drawing to use Unicode line drawing characters for span o… 
…utput

I bet we can find other uses for these sorts of characters in clarifying type
errors, etc.

This is marked as a "stable" flag for consistency with --color. However we
should reconsider both of them as part of rust-lang#19051. For these features to be
conveniently available with Cargo, we may want to use environment variables or
a config file.
73ee491
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Jul 14, 2016

All compiler flags at this point are essentially stable, modulo -Z, which is covered by #31847, so closing in favor of that.

@alexcrichton alexcrichton closed this Jul 14, 2016

@steveklabnik steveklabnik added the T-tools label Mar 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.