Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valgrind failure during unwinding in trans #19481

Closed
nikomatsakis opened this Issue Dec 3, 2014 · 6 comments

Comments

Assignees
No one assigned
Labels
P-medium
Projects
None yet
Milestone
No milestone
5 participants
@nikomatsakis @kmcallister @pnkfelix @tamird @brson
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Dec 3, 2014

I ran into a mysterious valgrind issue that I didn't have time to pin down. The problem seems to be involved with the handoff of ownership from caller to callee; valgrind reports reads of freed memory, basically. There is a "FIXME" commit that converts a fn that took Vec<T> to &[T], avoiding the problem (in this particular case, taking a Vec<T> was a bit silly anyhow).

nikomatsakis added a commit to nikomatsakis/rust that referenced this issue Dec 3, 2014

@nikomatsakis
FIXME(rust-lang#19481) -- workaround valgrind cleanup failure (but th… 
…e code is nicer this way anyhow)
931758c
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nikomatsakis commented Dec 3, 2014

Commit is 931758c
@kmcallister

This comment has been minimized.

Sign in to view
Copy link
Contributor

kmcallister commented Jan 19, 2015

Sounds like a lurking soundness issue. Nominating to revisit this.

@kmcallister kmcallister added the I-nominated label Jan 19, 2015

@pnkfelix

This comment has been minimized.

Sign in to view
Copy link
Member

pnkfelix commented Jan 22, 2015

P-low, not 1.0.

@pnkfelix pnkfelix added P-low P-medium and removed I-nominated P-low labels Jan 22, 2015

@pnkfelix

This comment has been minimized.

Sign in to view
Copy link
Member

pnkfelix commented Jan 22, 2015

(niko pushed for P-high instead)
@tamird

This comment has been minimized.

Sign in to view
Copy link
Contributor

tamird commented Nov 8, 2015

What's the action item here? Revert the fixme commit and run dst-object-from-unsized-type.rs?

@brson brson closed this Aug 4, 2016

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Aug 4, 2016

Old issue, lots of changes since.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.