Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust requires llvm.assume intrinsic and hence LLVM 3.6 #20010

Closed
anguslees opened this Issue Dec 19, 2014 · 6 comments

Comments

Projects
None yet
5 participants
@anguslees
Copy link
Contributor

anguslees commented Dec 19, 2014

The rust ./configure LLVM version check is only for 3.[2-6], yet #18080 adds a requirement on llvm.assume intrinsic. This intrinsic only appears in LLVM 3.6.

I think the version check needs to be updated accordingly - or only use the new optimisation intrinsic conditionally on building against newer LLVM.

@sanxiyn

This comment has been minimized.

Copy link
Member

sanxiyn commented Dec 19, 2014

FYI, minimal LLVM version was last updated in #5813. The reason was to support inline assembly.

@lucab

This comment has been minimized.

Copy link
Contributor

lucab commented Jan 19, 2015

Just as a note, current rust also fails to build against latest (external) stable LLVM 3.5.1 due to a newer EngineBuilder() signature picked-up by rustllvm/ExecutionEngineWrapper.cpp.
I didn't follow latest discussion about tracking LLVM releases, but I think the timing is good to decide which LLVM releases we want to target with 1.0.

@lucab

This comment has been minimized.

Copy link
Contributor

lucab commented Jan 22, 2015

Some discussion on this at http://discuss.rust-lang.org/t/targeted-llvm-for-1-0/1371/1. I may give a shot at this if I have some time.

@tamird

This comment has been minimized.

Copy link
Contributor

tamird commented May 30, 2015

Can this be closed now that LLVM 3.5.2 is out?

@anguslees

This comment has been minimized.

Copy link
Contributor Author

anguslees commented May 30, 2015

rustc needs at least LLVM 3.6 rc4 (afaik).

This issue is regarding the LLVM version check in ./configure, which is still 3.[2-6] (and the error message says "bad LLVM version: ... need >=3.0svn".

I believe the ./configure test should be tightened to >=3.6

tamird added a commit to tamird/rust that referenced this issue May 30, 2015

@sanxiyn

This comment has been minimized.

Copy link
Member

sanxiyn commented Oct 21, 2015

configure check was updated to >=3.5 in #23362 and it is still the case today. Rust successfully bootstraps against LLVM 3.5.2 release now.

@sanxiyn sanxiyn closed this Oct 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.