Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move coerce_match{,_calls} and related tests into run-pass-valgrind #21696

Closed
pnkfelix opened this Issue Jan 27, 2015 · 3 comments

Comments

Assignees

@pnkfelix pnkfelix

Labels
A-testsuite E-easy
Projects
None yet
Milestone
No milestone
3 participants
@pnkfelix @steveklabnik @brson
@pnkfelix
Copy link
Member

pnkfelix commented Jan 27, 2015

Put (copies of?) coerce_match{,_calls} and related tests into run-pass-valgrind. Because our current testing infrastructure is not aggressive enough in checking that tests like this are actually behaving in a sound manner.

spawned off of: #20055 (comment)

(I did not attempt this in PR #21692 because I wanted to expedite landing the fix for the trans bug.)

@pnkfelix pnkfelix added the A-testsuite label Jan 27, 2015

@pnkfelix

This comment has been minimized.

Sign in to view
Copy link
Member Author

pnkfelix commented Jan 28, 2015

@nick29581 clarified the situation to me: even if valgrind is not available on a host, the tests in run-pass-valgrind will be run (just without valgrind checking them).

So resolving this is probably just a matter of moving the tests over.

(having said that, I am wary of the risk of injecting usage of valgrind will cause a PR to be inadvertently blocked, and thus I still want to wait to fix this until after PR #21692 lands.)

@pnkfelix pnkfelix changed the title put copies of coerce_match{,_calls} and related tests into run-pass-valgrind move coerce_match{,_calls} and related tests into run-pass-valgrind Jan 30, 2015

@steveklabnik steveklabnik added the E-easy label Feb 8, 2016

@steveklabnik

This comment has been minimized.

Sign in to view
Copy link
Member

steveklabnik commented Feb 8, 2016

Triage: it looks like these two tests are not yet in src/test/run-pass-valgrind/. This should be easy to do, though which tests exactly are "related" isn't quite clear to me.
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Jun 27, 2016

Triage: no news.

@pnkfelix pnkfelix self-assigned this Jun 28, 2016

tamird added a commit to tamird/rust that referenced this issue Jul 24, 2016

@tamird
move coerce-match{,-calls} into run-pass-valgrind 
Closes rust-lang#21696.
Verified
This commit was signed with a verified signature.
@tamird tamird Tamir Duberstein
GPG key ID: 1C1E98CC8E17BB89 Learn about signing commits
9aca38e

@tamird tamird referenced this issue Jul 24, 2016

Merged

move coerce-match{,-calls} into run-pass-valgrind #35013

bors added a commit that referenced this issue Jul 26, 2016

@bors
Auto merge of #35013 - tamird:coerce-match-valgrind, r=alexcrichton 
move coerce-match{,-calls} into run-pass-valgrind

Closes #21696.
4045e1a

Manishearth added a commit to Manishearth/rust that referenced this issue Jul 28, 2016

@Manishearth
Rollup merge of rust-lang#35013 - tamird:coerce-match-valgrind, r=ale… 
…xcrichton

move coerce-match{,-calls} into run-pass-valgrind

Closes rust-lang#21696.
93c88eb

Manishearth added a commit to Manishearth/rust that referenced this issue Jul 28, 2016

@Manishearth
Rollup merge of rust-lang#35013 - tamird:coerce-match-valgrind, r=ale… 
…xcrichton

move coerce-match{,-calls} into run-pass-valgrind

Closes rust-lang#21696.
be6b73f

@bors bors closed this in #35013 Jul 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.