Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature-gate #[no_std] #21833

Closed
kmcallister opened this Issue Feb 1, 2015 · 2 comments

Comments

Assignees

@kmcallister kmcallister

Labels
A-syntaxext E-easy P-medium
Projects
None yet
Milestone
  1.0 beta
4 participants
@kmcallister @sfackler @pnkfelix @brson
@kmcallister
Copy link
Contributor

kmcallister commented Feb 1, 2015

It breaks various things at the syntax layer, e.g. #21827, #16803, #14342. I plan to fix those before the beta but I'm not sure what other issues there are.

@kmcallister kmcallister added A-syntaxext I-nominated labels Feb 1, 2015

@sfackler

This comment has been minimized.

Sign in to view
Copy link
Member

sfackler commented Feb 1, 2015

If we feature gate this, it'd be nice to move std injection either into expansion or after it. Right now you can't do #![cfg_attr(feature = "foo", no_std)], which means that crates that want to compile both in normal and no_std contexts have to use no_std. For example, take rust-phf: sfackler/rust-phf@24555b1.

@larsbergstrom larsbergstrom referenced this issue Feb 3, 2015

Closed

Tracking issue for Rust high-pri or blocking issues for Servo & Gecko #2853

0 of 1 task complete

@alexcrichton alexcrichton referenced this issue Feb 3, 2015

Closed

Fix syntax extensions for #![no_std] #21912

@brson brson added the E-easy label Feb 5, 2015

@pnkfelix

This comment has been minimized.

Sign in to view
Copy link
Member

pnkfelix commented Feb 5, 2015

1.0 beta

@pnkfelix pnkfelix added this to the 1.0 beta milestone Feb 5, 2015

@pnkfelix pnkfelix added P-medium and removed I-nominated labels Feb 5, 2015

@kmcallister kmcallister self-assigned this Feb 5, 2015

kmcallister added a commit to kmcallister/rust that referenced this issue Feb 6, 2015

@kmcallister
Feature-gate #![no_std] 
Fixes rust-lang#21833.

[breaking-change]
6d21ba9

kmcallister added a commit to kmcallister/rust that referenced this issue Feb 6, 2015

@kmcallister
Feature-gate #![no_std] 
Fixes rust-lang#21833.

[breaking-change]
0ef70b7

bors added a commit that referenced this issue Feb 7, 2015

@bors
Auto merge of #21988 - kmcallister:no-std, r=alexcrichton 
Fixes #21833.

[breaking-change]

r? @alexcrichton 

The tests in #21912 will also need `#[feature(no_std)]`. If you're okay with both PRs, I can merge and test them.
466df21

kmcallister added a commit to kmcallister/rust that referenced this issue Feb 7, 2015

@kmcallister
Feature-gate #![no_std] 
Fixes rust-lang#21833.

[breaking-change]
d788588

bors added a commit that referenced this issue Feb 8, 2015

@bors
Auto merge of #21988 - kmcallister:no-std, r=sfackler 
Fixes #21833.

[breaking-change]

r? @alexcrichton 

The tests in #21912 will also need `#[feature(no_std)]`. If you're okay with both PRs, I can merge and test them.
Loading status checks…
74b8740

@bors bors closed this in #21988 Feb 8, 2015

dlrobertson pushed a commit to dlrobertson/rust that referenced this issue Nov 29, 2018

@kmcallister @Manishearth
Feature-gate #![no_std] 
Fixes rust-lang#21833.

[breaking-change]
5ced430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.