Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change suffixes to `isize` and `usize` #22496

Closed
nikomatsakis opened this Issue Feb 18, 2015 · 5 comments

Comments

Projects
None yet
4 participants
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Feb 18, 2015

Tracking issue for rust-lang/rfcs#573

bors added a commit that referenced this issue Feb 19, 2015

Auto merge of #22497 - nikomatsakis:suffixes, r=alexcrichton
The old suffixes now issue warnings unless a feature-gate is given.

Fixes #22496.

r? @alexcrichton

bors added a commit that referenced this issue Feb 19, 2015

Auto merge of #22497 - nikomatsakis:suffixes, r=alexcrichton
The old suffixes now issue warnings unless a feature-gate is given.

Fixes #22496.

r? @alexcrichton

bors added a commit that referenced this issue Feb 19, 2015

Auto merge of #22497 - nikomatsakis:suffixes, r=alexcrichton
The old suffixes now issue warnings unless a feature-gate is given.

Fixes #22496.

r? @alexcrichton

bors added a commit that referenced this issue Feb 19, 2015

Auto merge of #22497 - nikomatsakis:suffixes, r=alexcrichton
The old suffixes now issue warnings unless a feature-gate is given.

Fixes #22496.

r? @alexcrichton

@bors bors closed this in #22497 Feb 19, 2015

@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Apr 13, 2015

Reopening, apparently us/is is still being silently accepted?

Example on playpen:

fn main() {
    let foo = 2us;
    println!("foo: {}", foo);
}

See also http://internals.rust-lang.org/t/how-did-the-is-us-suffixes-survive/1871

@pnkfelix pnkfelix reopened this Apr 13, 2015

@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Apr 13, 2015

Nominating: I want to figure out if a fix for this needs to be backported to beta, or to 1.0, or if we are stuck accepting it for now (or forever).

@nikomatsakis

This comment has been minimized.

Copy link
Contributor Author

nikomatsakis commented Apr 14, 2015

The problem seems to be in this commit: 54f16b8

@nikomatsakis

This comment has been minimized.

Copy link
Contributor Author

nikomatsakis commented Apr 14, 2015

Specifically here.

@brson brson self-assigned this Apr 14, 2015

@brson

This comment has been minimized.

Copy link
Contributor

brson commented Apr 14, 2015

I'll put a patch together.

brson added a commit to brson/rust that referenced this issue Apr 15, 2015

brson added a commit to brson/rust that referenced this issue Apr 15, 2015

Forbid is/us suffixes. Fixes rust-lang#22496
It was an oversight that this was not done in the great int upheaval.

[breaking-change]

@brson brson closed this in 5a3a599 Apr 16, 2015

andersk added a commit to andersk/redhook that referenced this issue Apr 25, 2015

-1is was renamed to -1isize
rust-lang/rust#22496

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.