Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no way to create a PathBuf from an OsString without copying #22751

Closed
lilyball opened this Issue Feb 24, 2015 · 6 comments

Comments

Assignees

@aturon aturon

Labels
E-easy
Projects
None yet
Milestone
  1.0 beta
6 participants
@lilyball @aturon @LukasKalbertodt @alexcrichton @retep998 @pnkfelix
@lilyball
Copy link
Contributor

lilyball commented Feb 24, 2015

PathBuf doesn't expose any methods that can be used to create a PathBuf from an OsString (or anything convertible to an OsString) without copying. This seems like an unnecessary limitation.

/cc @aturon
@aturon

This comment has been minimized.

Sign in to view
Copy link
Member

aturon commented Feb 24, 2015

Yep, just an oversight.

@aturon aturon added A-libs E-easy labels Feb 24, 2015

@LukasKalbertodt

This comment has been minimized.

Sign in to view
Copy link
Contributor

LukasKalbertodt commented Feb 25, 2015

Just add fn from_os_string(_: OsString) -> PathBuf to PathBuf? That seems too easy...
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Feb 25, 2015

I think that this would probably be done by changing the AsOsStr bound on PathBuf::new instead to IntoOsString as one may also wish to construct a PathBuf from a String for example.
@retep998

This comment has been minimized.

Sign in to view
Copy link
Member

retep998 commented Mar 12, 2015

cc me. I need this.

@lilyball lilyball added the I-nominated label Mar 15, 2015

@lilyball

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

lilyball commented Mar 15, 2015

Nominating, I think this should be done before 1.0 as it may be a confusing omission.
@pnkfelix

This comment has been minimized.

Sign in to view
Copy link
Member

pnkfelix commented Mar 19, 2015

1.0 beta, P-backcompat-libs (but only b/c @aturon said he's got a patch ready to go)

@pnkfelix pnkfelix added this to the 1.0 beta milestone Mar 19, 2015

@pnkfelix pnkfelix added the P-backcompat-libs label Mar 19, 2015

@alexcrichton alexcrichton removed the I-nominated label Mar 19, 2015

aturon added a commit to aturon/rust that referenced this issue Mar 20, 2015

@aturon
Add generic conversion traits 
This commit:

* Introduces `std::convert`, providing an implementation of
RFC 529.

* Deprecates the `AsPath`, `AsOsStr`, and `IntoBytes` traits, all
in favor of the corresponding generic conversion traits.

  Consequently, various IO APIs now take `As<Path>` rather than
`AsPath`, and so on. Since the types provided by `std` implement both
traits, this should cause relatively little breakage.

* Deprecates many `from_foo` constructors in favor of `from`.

* Changes `PathBuf::new` to take no argument (creating an empty buffer,
  as per convention). The previous behavior is now available as
  `PathBuf::from`.

* De-stabilizes `IntoCow`. It's not clear whether we need this separate trait.

Closes rust-lang#22751

[breaking-change]
9fcd79f

@aturon aturon referenced this issue Mar 20, 2015

Closed

Add generic conversion traits #23538

aturon added a commit to aturon/rust that referenced this issue Mar 20, 2015

@aturon
Add generic conversion traits 
This commit:

* Introduces `std::convert`, providing an implementation of
RFC 529.

* Deprecates the `AsPath`, `AsOsStr`, and `IntoBytes` traits, all
in favor of the corresponding generic conversion traits.

  Consequently, various IO APIs now take `As<Path>` rather than
`AsPath`, and so on. Since the types provided by `std` implement both
traits, this should cause relatively little breakage.

* Deprecates many `from_foo` constructors in favor of `from`.

* Changes `PathBuf::new` to take no argument (creating an empty buffer,
  as per convention). The previous behavior is now available as
  `PathBuf::from`.

* De-stabilizes `IntoCow`. It's not clear whether we need this separate trait.

Closes rust-lang#22751

[breaking-change]
844c115

aturon added a commit to aturon/rust that referenced this issue Mar 20, 2015

@aturon
Add generic conversion traits 
This commit:

* Introduces `std::convert`, providing an implementation of
RFC 529.

* Deprecates the `AsPath`, `AsOsStr`, and `IntoBytes` traits, all
in favor of the corresponding generic conversion traits.

  Consequently, various IO APIs now take `As<Path>` rather than
`AsPath`, and so on. Since the types provided by `std` implement both
traits, this should cause relatively little breakage.

* Deprecates many `from_foo` constructors in favor of `from`.

* Changes `PathBuf::new` to take no argument (creating an empty buffer,
  as per convention). The previous behavior is now available as
  `PathBuf::from`.

* De-stabilizes `IntoCow`. It's not clear whether we need this separate trait.

Closes rust-lang#22751

[breaking-change]
85ab341

aturon added a commit to aturon/rust that referenced this issue Mar 20, 2015

@aturon
Add generic conversion traits 
This commit:

* Introduces `std::convert`, providing an implementation of
RFC 529.

* Deprecates the `AsPath`, `AsOsStr`, and `IntoBytes` traits, all
in favor of the corresponding generic conversion traits.

  Consequently, various IO APIs now take `As<Path>` rather than
`AsPath`, and so on. Since the types provided by `std` implement both
traits, this should cause relatively little breakage.

* Deprecates many `from_foo` constructors in favor of `from`.

* Changes `PathBuf::new` to take no argument (creating an empty buffer,
  as per convention). The previous behavior is now available as
  `PathBuf::from`.

* De-stabilizes `IntoCow`. It's not clear whether we need this separate trait.

Closes rust-lang#22751

[breaking-change]
16e7b47

aturon added a commit to aturon/rust that referenced this issue Mar 20, 2015

@aturon
Add generic conversion traits 
This commit:

* Introduces `std::convert`, providing an implementation of
RFC 529.

* Deprecates the `AsPath`, `AsOsStr`, and `IntoBytes` traits, all
in favor of the corresponding generic conversion traits.

  Consequently, various IO APIs now take `As<Path>` rather than
`AsPath`, and so on. Since the types provided by `std` implement both
traits, this should cause relatively little breakage.

* Deprecates many `from_foo` constructors in favor of `from`.

* Changes `PathBuf::new` to take no argument (creating an empty buffer,
  as per convention). The previous behavior is now available as
  `PathBuf::from`.

* De-stabilizes `IntoCow`. It's not clear whether we need this separate trait.

Closes rust-lang#22751

[breaking-change]
96e8cc4

aturon added a commit to aturon/rust that referenced this issue Mar 20, 2015

@aturon
Add generic conversion traits 
This commit:

* Introduces `std::convert`, providing an implementation of
RFC 529.

* Deprecates the `AsPath`, `AsOsStr`, and `IntoBytes` traits, all
in favor of the corresponding generic conversion traits.

  Consequently, various IO APIs now take `As<Path>` rather than
`AsPath`, and so on. Since the types provided by `std` implement both
traits, this should cause relatively little breakage.

* Deprecates many `from_foo` constructors in favor of `from`.

* Changes `PathBuf::new` to take no argument (creating an empty buffer,
  as per convention). The previous behavior is now available as
  `PathBuf::from`.

* De-stabilizes `IntoCow`. It's not clear whether we need this separate trait.

Closes rust-lang#22751

[breaking-change]
0f110c0

aturon added a commit to aturon/rust that referenced this issue Mar 20, 2015

@aturon
Add generic conversion traits 
This commit:

* Introduces `std::convert`, providing an implementation of
RFC 529.

* Deprecates the `AsPath`, `AsOsStr`, and `IntoBytes` traits, all
in favor of the corresponding generic conversion traits.

  Consequently, various IO APIs now take `As<Path>` rather than
`AsPath`, and so on. Since the types provided by `std` implement both
traits, this should cause relatively little breakage.

* Deprecates many `from_foo` constructors in favor of `from`.

* Changes `PathBuf::new` to take no argument (creating an empty buffer,
  as per convention). The previous behavior is now available as
  `PathBuf::from`.

* De-stabilizes `IntoCow`. It's not clear whether we need this separate trait.

Closes rust-lang#22751

[breaking-change]
c8671be

aturon added a commit to aturon/rust that referenced this issue Mar 20, 2015

@aturon
Add generic conversion traits 
This commit:

* Introduces `std::convert`, providing an implementation of
RFC 529.

* Deprecates the `AsPath`, `AsOsStr`, and `IntoBytes` traits, all
in favor of the corresponding generic conversion traits.

  Consequently, various IO APIs now take `As<Path>` rather than
`AsPath`, and so on. Since the types provided by `std` implement both
traits, this should cause relatively little breakage.

* Deprecates many `from_foo` constructors in favor of `from`.

* Changes `PathBuf::new` to take no argument (creating an empty buffer,
  as per convention). The previous behavior is now available as
  `PathBuf::from`.

* De-stabilizes `IntoCow`. It's not clear whether we need this separate trait.

Closes rust-lang#22751
Closes rust-lang#14433

[breaking-change]
3c62067

aturon added a commit to aturon/rust that referenced this issue Mar 23, 2015

@aturon
Add generic conversion traits 
This commit:

* Introduces `std::convert`, providing an implementation of
RFC 529.

* Deprecates the `AsPath`, `AsOsStr`, and `IntoBytes` traits, all
in favor of the corresponding generic conversion traits.

  Consequently, various IO APIs now take `As<Path>` rather than
`AsPath`, and so on. Since the types provided by `std` implement both
traits, this should cause relatively little breakage.

* Deprecates many `from_foo` constructors in favor of `from`.

* Changes `PathBuf::new` to take no argument (creating an empty buffer,
  as per convention). The previous behavior is now available as
  `PathBuf::from`.

* De-stabilizes `IntoCow`. It's not clear whether we need this separate trait.

Closes rust-lang#22751
Closes rust-lang#14433

[breaking-change]
dbd9480

aturon added a commit to aturon/rust that referenced this issue Mar 23, 2015

@aturon
Add generic conversion traits 
This commit:

* Introduces `std::convert`, providing an implementation of
RFC 529.

* Deprecates the `AsPath`, `AsOsStr`, and `IntoBytes` traits, all
in favor of the corresponding generic conversion traits.

  Consequently, various IO APIs now take `AsRef<Path>` rather than
`AsPath`, and so on. Since the types provided by `std` implement both
traits, this should cause relatively little breakage.

* Deprecates many `from_foo` constructors in favor of `from`.

* Changes `PathBuf::new` to take no argument (creating an empty buffer,
  as per convention). The previous behavior is now available as
  `PathBuf::from`.

* De-stabilizes `IntoCow`. It's not clear whether we need this separate trait.

Closes rust-lang#22751
Closes rust-lang#14433

[breaking-change]
a686d27

aturon added a commit to aturon/rust that referenced this issue Mar 23, 2015

@aturon
Add generic conversion traits 
This commit:

* Introduces `std::convert`, providing an implementation of
RFC 529.

* Deprecates the `AsPath`, `AsOsStr`, and `IntoBytes` traits, all
in favor of the corresponding generic conversion traits.

  Consequently, various IO APIs now take `AsRef<Path>` rather than
`AsPath`, and so on. Since the types provided by `std` implement both
traits, this should cause relatively little breakage.

* Deprecates many `from_foo` constructors in favor of `from`.

* Changes `PathBuf::new` to take no argument (creating an empty buffer,
  as per convention). The previous behavior is now available as
  `PathBuf::from`.

* De-stabilizes `IntoCow`. It's not clear whether we need this separate trait.

Closes rust-lang#22751
Closes rust-lang#14433

[breaking-change]
97c8e43

aturon added a commit to aturon/rust that referenced this issue Mar 23, 2015

@aturon
Add generic conversion traits 
This commit:

* Introduces `std::convert`, providing an implementation of
RFC 529.

* Deprecates the `AsPath`, `AsOsStr`, and `IntoBytes` traits, all
in favor of the corresponding generic conversion traits.

  Consequently, various IO APIs now take `AsRef<Path>` rather than
`AsPath`, and so on. Since the types provided by `std` implement both
traits, this should cause relatively little breakage.

* Deprecates many `from_foo` constructors in favor of `from`.

* Changes `PathBuf::new` to take no argument (creating an empty buffer,
  as per convention). The previous behavior is now available as
  `PathBuf::from`.

* De-stabilizes `IntoCow`. It's not clear whether we need this separate trait.

Closes rust-lang#22751
Closes rust-lang#14433

[breaking-change]
08ee682

@alexcrichton alexcrichton assigned aturon Mar 24, 2015

@aturon aturon closed this in 8389253 Mar 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.