Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std::prelude::v1 still references old_path and old_io #23377

Closed
lilyball opened this Issue Mar 15, 2015 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  1.0 beta
2 participants
@lilyball @pnkfelix
@lilyball
Copy link
Contributor

lilyball commented Mar 15, 2015

std::prelude::v1 is still importing items from std::old_path and std::old_io, which are both now deprecated. The prelude should be updated to import the relevant items from std::path and std::io instead. std::prelude::v1 is already marked stable, which seems like a mistake given that it contained these old items. We could transition to a new std::prelude::v2, but it seems odd to do that before Rust 1.0, so I think we should accept that it was incorrectly stabilized and modify std::prelude::v1.

/cc @alexcrichton

@lilyball lilyball referenced this issue Mar 15, 2015

Closed

std::io::prelude should stop renaming Seek #23378

@lilyball lilyball added the I-nominated label Mar 15, 2015

@lilyball

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

lilyball commented Mar 15, 2015

Since std::prelude::v1 still re-exports std::old_io::Writer it turns out that you cannot use the write!() macro after importing std::io::prelude::* (or std::io::Write) on a type that implements both std::old_io::Writer and std::io::Write as it results in an ambiguous call to write_fmt(). An example of this is Vec<u8>.

alexcrichton added a commit to alexcrichton/rust that referenced this issue Mar 18, 2015

@alexcrichton
std: Remove old_io/old_path from the prelude 
This commit removes the reexports of `old_io` traits as well as `old_path` types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like `Seek` in the `std::io`
module (currently reexported as `NewSeek` in the io prelude).

Closes rust-lang#23377
Closes rust-lang#23378
a2d613a

@alexcrichton alexcrichton referenced this issue Mar 18, 2015

Merged

std: Remove old_io/old_path from the prelude #23470

alexcrichton added a commit to alexcrichton/rust that referenced this issue Mar 18, 2015

@alexcrichton
std: Remove old_io/old_path from the prelude 
This commit removes the reexports of `old_io` traits as well as `old_path` types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like `Seek` in the `std::io`
module (currently reexported as `NewSeek` in the io prelude).

Closes rust-lang#23377
Closes rust-lang#23378
47cb40d

Manishearth added a commit to Manishearth/rust that referenced this issue Mar 19, 2015

@Manishearth
Rollup merge of rust-lang#23470 - alexcrichton:less-prelude, r=aturon 
 This commit removes the reexports of `old_io` traits as well as `old_path` types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like `Seek` in the `std::io`
module (currently reexported as `NewSeek` in the io prelude).

Closes rust-lang#23377
Closes rust-lang#23378
369ecc3

Manishearth added a commit to Manishearth/rust that referenced this issue Mar 19, 2015

@Manishearth
Rollup merge of rust-lang#23470 - alexcrichton:less-prelude, r=aturon 
 This commit removes the reexports of `old_io` traits as well as `old_path` types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like `Seek` in the `std::io`
module (currently reexported as `NewSeek` in the io prelude).

Closes rust-lang#23377
Closes rust-lang#23378
dc1fa4d

bors added a commit that referenced this issue Mar 19, 2015

@bors
Auto merge of #23470 - alexcrichton:less-prelude, r=aturon 
This commit removes the reexports of `old_io` traits as well as `old_path` types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like `Seek` in the `std::io`
module (currently reexported as `NewSeek` in the io prelude).

Closes #23377
Closes #23378
e4e647e

alexcrichton added a commit to alexcrichton/rust that referenced this issue Mar 19, 2015

@alexcrichton
std: Remove old_io/old_path from the prelude 
This commit removes the reexports of `old_io` traits as well as `old_path` types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like `Seek` in the `std::io`
module (currently reexported as `NewSeek` in the io prelude).

Closes rust-lang#23377
Closes rust-lang#23378
c3eb592
@pnkfelix

This comment has been minimized.

Sign in to view
Copy link
Member

pnkfelix commented Mar 19, 2015

1.0 beta, P-backcompat-libs. ( @alexcrichton says there's a PR in the queue.)

@pnkfelix pnkfelix added this to the 1.0 beta milestone Mar 19, 2015

@pnkfelix pnkfelix added P-backcompat-libs and removed I-nominated labels Mar 19, 2015

Manishearth added a commit to Manishearth/rust that referenced this issue Mar 20, 2015

@Manishearth
Rollup merge of rust-lang#23470 - alexcrichton:less-prelude, r=aturon 
 This commit removes the reexports of `old_io` traits as well as `old_path` types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like `Seek` in the `std::io`
module (currently reexported as `NewSeek` in the io prelude).

Closes rust-lang#23377
Closes rust-lang#23378
536306e

bors added a commit that referenced this issue Mar 20, 2015

@bors
Auto merge of #23470 - alexcrichton:less-prelude, r=aturon 
This commit removes the reexports of `old_io` traits as well as `old_path` types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like `Seek` in the `std::io`
module (currently reexported as `NewSeek` in the io prelude).

Closes #23377
Closes #23378
52830ab

alexcrichton added a commit to alexcrichton/rust that referenced this issue Mar 20, 2015

@alexcrichton
std: Remove old_io/old_path from the prelude 
This commit removes the reexports of `old_io` traits as well as `old_path` types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like `Seek` in the `std::io`
module (currently reexported as `NewSeek` in the io prelude).

Closes rust-lang#23377
Closes rust-lang#23378
b962ec0

bors added a commit that referenced this issue Mar 20, 2015

@bors
Auto merge of #23470 - alexcrichton:less-prelude, r=aturon 
This commit removes the reexports of `old_io` traits as well as `old_path` types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like `Seek` in the `std::io`
module (currently reexported as `NewSeek` in the io prelude).

Closes #23377
Closes #23378
d5c590a

alexcrichton added a commit to alexcrichton/rust that referenced this issue Mar 20, 2015

@alexcrichton
std: Remove old_io/old_path from the prelude 
This commit removes the reexports of `old_io` traits as well as `old_path` types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like `Seek` in the `std::io`
module (currently reexported as `NewSeek` in the io prelude).

Closes rust-lang#23377
Closes rust-lang#23378
bc09a97

bors added a commit that referenced this issue Mar 20, 2015

@bors
Auto merge of #23470 - alexcrichton:less-prelude, r=aturon 
This commit removes the reexports of `old_io` traits as well as `old_path` types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like `Seek` in the `std::io`
module (currently reexported as `NewSeek` in the io prelude).

Closes #23377
Closes #23378
d56eb07

alexcrichton added a commit to alexcrichton/rust that referenced this issue Mar 20, 2015

@alexcrichton
std: Remove old_io/old_path from the prelude 
This commit removes the reexports of `old_io` traits as well as `old_path` types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like `Seek` in the `std::io`
module (currently reexported as `NewSeek` in the io prelude).

Closes rust-lang#23377
Closes rust-lang#23378
e8daec8

bors added a commit that referenced this issue Mar 21, 2015

@bors
Auto merge of #23470 - alexcrichton:less-prelude, r=aturon 
This commit removes the reexports of `old_io` traits as well as `old_path` types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like `Seek` in the `std::io`
module (currently reexported as `NewSeek` in the io prelude).

Closes #23377
Closes #23378
eaf8fe0

alexcrichton added a commit to alexcrichton/rust that referenced this issue Mar 21, 2015

@alexcrichton
std: Remove old_io/old_path from the prelude 
This commit removes the reexports of `old_io` traits as well as `old_path` types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like `Seek` in the `std::io`
module (currently reexported as `NewSeek` in the io prelude).

Closes rust-lang#23377
Closes rust-lang#23378
212e031

bors added a commit that referenced this issue Mar 21, 2015

@bors
Auto merge of #23470 - alexcrichton:less-prelude, r=aturon 
This commit removes the reexports of `old_io` traits as well as `old_path` types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like `Seek` in the `std::io`
module (currently reexported as `NewSeek` in the io prelude).

Closes #23377
Closes #23378
Loading status checks…
ecf8c64

@bors bors closed this in #23470 Mar 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.