Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRust Docs should not include internal crates #23772
Comments
This comment has been minimized.
This comment has been minimized.
|
I also feel that we should not have duplicate |
This comment has been minimized.
This comment has been minimized.
|
Paring down what shows up in rustdoc is going to be a key step for 1.0 readiness. Nominating P-high, 1.0 polish. triage: I-nominated () |
rust-highfive
added
the
I-nominated
label
Mar 27, 2015
aturon
added
A-docs
T-rustdoc
labels
Mar 27, 2015
This comment has been minimized.
This comment has been minimized.
|
cc me, ideally there'll be a frob to still specify the old behaviour. rustdoc has been invaluable when I'm spelunking for something. |
This comment has been minimized.
This comment has been minimized.
|
@richo Yes indeed, it's important that this is still available in some form for people who want to hack on Rust itself. |
This comment has been minimized.
This comment has been minimized.
+1 |
This comment has been minimized.
This comment has been minimized.
|
I swear there was a pretty old open issue for this already but I can't find it. Also cc #22083 which is important and related. |
This comment has been minimized.
This comment has been minimized.
This would be addressed for the common Rust user by just removing internal crates (including core) from the docs for the release channel. Nightly users, or at least users of core, and people working on the Rust distribution itself are likely going to want to retain item duplication between core and std because it matters to them. If you initiate your search from std/core then entries in those crates will come first anyway. |
steveklabnik
removed
the
A-docs
label
Mar 27, 2015
This comment has been minimized.
This comment has been minimized.
|
Duplicate of #21297 |
This comment has been minimized.
This comment has been minimized.
|
I'll have a PR for this soon (it's testing) |
wycats commentedMar 27, 2015
For example, when I was originally searching for serialize (in the wrong place, I suppose), I got a bunch of internal results. Link to the search.