Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can define a associated type more than once #23969

Closed
Kimundi opened this Issue Apr 2, 2015 · 3 comments

Comments

Assignees
No one assigned
Labels
A-associated-items A-typesystem P-medium
Projects
None yet
Milestone
No milestone
7 participants
@Kimundi @alexcrichton @pnkfelix @brson @nikomatsakis @nrc @rust-highfive
@Kimundi
Copy link
Member

Kimundi commented Apr 2, 2015 

trait Foo {
    type Ty;
}

impl Foo for () {
    type Ty = ();
    type Ty = usize;
}

fn main() { 
    let _: <() as Foo>::Ty = ();
}

This erroneously parses and compiles fine, the compiler seems to use the first definition of Ty in the impl.

This might have been introduced by #23265, ping @eddyb.

@Kimundi Kimundi added the A-parser label Apr 2, 2015

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Apr 2, 2015

triage: I-nominated

@rust-highfive rust-highfive added the I-nominated label Apr 2, 2015

@nikomatsakis nikomatsakis added the A-associated-items label Apr 2, 2015

@nrc nrc added A-associated-items and removed A-associated-items A-parser labels Apr 2, 2015

@pnkfelix

This comment has been minimized.

Sign in to view
Copy link
Member

pnkfelix commented Apr 2, 2015

classifying as just a bug. P-backcompat-lang, not 1.0 blocker.

@pnkfelix pnkfelix added P-backcompat-lang and removed I-nominated labels Apr 2, 2015

@brson brson added P-medium A-typesystem and removed P-backcompat-lang labels Apr 24, 2015

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Apr 24, 2015

Demoting this to P-medium. Somebody should get on it though!

nham pushed a commit to nham/rust that referenced this issue Jun 3, 2015

Nick Hamann
Detect duplicate implementations of assoc. types and constants. 
Fixes rust-lang#23969.
ea82235

nham pushed a commit to nham/rust that referenced this issue Jun 3, 2015

Nick Hamann
Detect duplicate implementations of assoc. types and constants. 
Adds error codes E0398 and E0399.

Fixes rust-lang#23969.
98daaca

nham pushed a commit to nham/rust that referenced this issue Jun 3, 2015

Nick Hamann
Detect duplicate implementations of assoc. types and constants. 
Adds error codes E0398 and E0399.

Fixes rust-lang#23969.
7ac997d

@nham nham referenced this issue Jun 3, 2015

Merged

Detect duplicate implementations of assoc. types and constants. #25993

nham pushed a commit to nham/rust that referenced this issue Jun 16, 2015

Nick Hamann
Detect duplicate implementations of assoc. types and constants. 
Adds error codes E0398 and E0399.

Fixes rust-lang#23969.
299e728

nham pushed a commit to nham/rust that referenced this issue Jul 15, 2015

Nick Hamann
Better detection of duplicate associated items. 
Expands E0201 to be used for any duplicate associated items, not just duplicate
methods/functions. It also correctly detects when two different kinds of items
(like a constant and a method) have the same name.

Fixes rust-lang#23969.
560bb0a

bors added a commit that referenced this issue Jul 16, 2015

@bors
Auto merge of #25993 - nham:fix_23969, r=nikomatsakis 
Adds two error codes, one for duplicate associated constants and one for types. I'm not certain these should each have their own code, but E0201 is already solely for duplicate associated functions so at least it kinda matches. This will lead to somewhat redundant error explanations, but that's nothing new!

Fixes #23969.
8690536

bors added a commit that referenced this issue Jul 17, 2015

@bors
Auto merge of #25993 - nham:fix_23969, r=nikomatsakis 
Adds two error codes, one for duplicate associated constants and one for types. I'm not certain these should each have their own code, but E0201 is already solely for duplicate associated functions so at least it kinda matches. This will lead to somewhat redundant error explanations, but that's nothing new!

Fixes #23969.
898e18d

bors added a commit that referenced this issue Jul 17, 2015

@bors
Auto merge of #25993 - nham:fix_23969, r=nikomatsakis 
Adds two error codes, one for duplicate associated constants and one for types. I'm not certain these should each have their own code, but E0201 is already solely for duplicate associated functions so at least it kinda matches. This will lead to somewhat redundant error explanations, but that's nothing new!

Fixes #23969.
bab630e

bors added a commit that referenced this issue Jul 17, 2015

@bors
Auto merge of #25993 - nham:fix_23969, r=nikomatsakis 
Adds two error codes, one for duplicate associated constants and one for types. I'm not certain these should each have their own code, but E0201 is already solely for duplicate associated functions so at least it kinda matches. This will lead to somewhat redundant error explanations, but that's nothing new!

Fixes #23969.
5930c94

Manishearth added a commit to Manishearth/rust that referenced this issue Jul 17, 2015

@Manishearth
Rollup merge of rust-lang#25993 - nham:fix_23969, r=nikomatsakis 
Adds two error codes, one for duplicate associated constants and one for types. I'm not certain these should each have their own code, but E0201 is already solely for duplicate associated functions so at least it kinda matches. This will lead to somewhat redundant error explanations, but that's nothing new!

Fixes rust-lang#23969.
ef9b9ce

bors added a commit that referenced this issue Jul 17, 2015

@bors
Auto merge of #25993 - nham:fix_23969, r=nikomatsakis 
Adds two error codes, one for duplicate associated constants and one for types. I'm not certain these should each have their own code, but E0201 is already solely for duplicate associated functions so at least it kinda matches. This will lead to somewhat redundant error explanations, but that's nothing new!

Fixes #23969.
d977c82

bors added a commit that referenced this issue Jul 17, 2015

@bors
Auto merge of #25993 - nham:fix_23969, r=nikomatsakis 
Adds two error codes, one for duplicate associated constants and one for types. I'm not certain these should each have their own code, but E0201 is already solely for duplicate associated functions so at least it kinda matches. This will lead to somewhat redundant error explanations, but that's nothing new!

Fixes #23969.
57dcda1

@bors bors closed this in #25993 Jul 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.