Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs::create_dir_all fails for directory junctions on Windows #26716

Closed
alexcrichton opened this Issue Jul 1, 2015 · 3 comments

Comments

Assignees
No one assigned
Labels
P-high T-libs regression-from-stable-to-nightly
Projects
None yet
Milestone
No milestone
3 participants
@alexcrichton @brson @rust-highfive
@alexcrichton
Copy link
Member

alexcrichton commented Jul 1, 2015

First reported in rust-lang/cargo#1749, it looks like if an intermediate directory is a junction on Windows then fs::create_dir_all will fail. Unfortunately the standard library doesn't provide away to create a junction, but a setup like this should work:

mkdir foo
mklink /J bar foo
use std::fs;
fs::create_dir_all("bar/test").unwrap() // this fails
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Jul 1, 2015

The Cargo report claims this was a regression, so I'm going to nominate this.

@alexcrichton alexcrichton added the I-nominated label Jul 1, 2015

@alexcrichton alexcrichton referenced this issue Jul 1, 2015

Closed

Cargo included in Rust 1.1 can no longer build in Windows NTFS junctions #1749

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Jul 1, 2015

I suspect fs::metadata(&junction).is_dir() is returning false (when it should perhaps return true), but I have not had a chance to investigate this too closely.

@alexcrichton alexcrichton added the T-libs label Jul 1, 2015

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Jul 8, 2015

triage: P-high

@rust-highfive rust-highfive added P-high and removed I-nominated labels Jul 8, 2015

@brson brson added I-nominated regression-from-stable-to-nightly P-high and removed P-high labels Jul 8, 2015

@alexcrichton alexcrichton removed the I-nominated label Jul 8, 2015

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 9, 2015

@alexcrichton
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
9bd1962

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 9, 2015

@alexcrichton
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
606c1a9

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 9, 2015

@alexcrichton
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
937f009

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 9, 2015

@alexcrichton
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
4692992

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 9, 2015

@alexcrichton
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
48e0cad

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 9, 2015

@alexcrichton
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
028513d

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 9, 2015

@alexcrichton
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
ba6b2af

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 9, 2015

@alexcrichton
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
765e7ec

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 9, 2015

@alexcrichton
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
9a7932d

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 9, 2015

@alexcrichton
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
5d76585

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 9, 2015

@alexcrichton
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
13c08e7

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 9, 2015

@alexcrichton
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
045565a

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 9, 2015

@alexcrichton
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
33f76f8

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 9, 2015

@alexcrichton
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
2c6a8dd

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 9, 2015

@alexcrichton
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
c4db443

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 9, 2015

@alexcrichton
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
31fe560

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 9, 2015

@alexcrichton
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
d81ec9d

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 9, 2015

@alexcrichton
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
6fdf479

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 9, 2015

@alexcrichton
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
e8c48ea

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 9, 2015

@alexcrichton
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
dd7cafd

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 9, 2015

@alexcrichton
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
fe48561

@alexcrichton alexcrichton referenced this issue Jul 9, 2015

Merged

std: Consider directory junctions as directories #26929

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 9, 2015

@alexcrichton
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
b612d3b

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 10, 2015

@alexcrichton
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
72750c7

bors added a commit that referenced this issue Jul 10, 2015

@bors
Auto merge of #26929 - alexcrichton:windows-dir-junction, r=brson 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes #26716
30aeaba

bors added a commit that referenced this issue Jul 11, 2015

@bors
Auto merge of #26929 - alexcrichton:windows-dir-junction, r=brson 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes #26716
Loading status checks…
64db3aa

@bors bors closed this in #26929 Jul 11, 2015

jroesch added a commit to jroesch/rust that referenced this issue Jul 21, 2015

@alexcrichton @jroesch
std: Consider directory junctions as directories 
Previously on Windows a directory junction would return false from `is_dir`,
causing various odd behavior, specifically calls to `create_dir_all` might fail
when they would otherwise continue to succeed.

Closes rust-lang#26716
9821d16

@alexcrichton alexcrichton referenced this issue Feb 3, 2016

Merged

Enable more fs tests on Windows #31360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.