Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing debuginfo test #27514

Closed
dotdash opened this Issue Aug 4, 2015 · 8 comments

Comments

Projects
None yet
7 participants
@dotdash
Copy link
Contributor

dotdash commented Aug 4, 2015

The test that was restored in #27500 fails for me:

failures:

---- [debuginfo-gdb] debuginfo/gdb-pretty-struct-and-enums.rs stdout ----
        NOTE: compiletest thinks it is using GDB version 7.7

error: line not found in debugger output: $13 = Some = {"abc"}
status: exit code: 0
command: gdb -quiet -batch -nx -command=x86_64-unknown-linux-gnu/test/debuginfo-gdb/gdb-pretty-struct-and-enums.debugger.script
stdout:
------------------------------------------
GNU gdb (Debian 7.7.1+dfsg-5) 7.7.1
Copyright (C) 2014 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word".
Breakpoint 1 at 0xca8: file /home/doener/src/rust-submit/src/test/debuginfo/gdb-pretty-struct-and-enums.rs, line 185.
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".

Breakpoint 1, gdb_pretty_struct_and_enums::main () at /home/doener/src/rust-submit/src/test/debuginfo/gdb-pretty-struct-and-enums.rs:185
185         zzz(); // #break
$1 = RegularStruct = {the_first_field = 101, the_second_field = 102.5, the_third_field = false, the_fourth_field = "I'm so pretty, oh so pretty..."}
$2 = {true, 103, "blub"}
$3 = TupleStruct = {-104.5, 105}
$4 = EmptyStruct
$5 = CStyleEnumVar1
$6 = CStyleEnumVar2
$7 = CStyleEnumVar3
$8 = MixedEnumCStyleVar
$9 = MixedEnumTupleVar = {106, 107, false}
$10 = MixedEnumStructVar = {field1 = 108.5, field2 = 109}
$11 = Some = {110}
$12 = None
$13 = {RUST$ENCODED$ENUM$0$0$None = Some = {"abc"}}
$14 = {RUST$ENCODED$ENUM$0$0$None = Some = {""}}
$15 = NestedVariant1 = {NestedStruct = {regular_struct = RegularStruct = {the_first_field = 111, the_second_field = 112.5, the_third_field = true, the_fourth_field = "NestedStructString1"}, tuple_struct = TupleStruct = {113.5, 114}, empty_struct = EmptyStruct, c_style_enum = CStyleEnumVar2, mixed_enum = MixedEnumTupleVar = {115, 116, false}}}
$16 = NestedVariant2 = {abc = NestedStruct = {regular_struct = RegularStruct = {the_first_field = 117, the_second_field = 118.5, the_third_field = false, the_fourth_field = "NestedStructString10"}, tuple_struct = TupleStruct = {119.5, 120}, empty_struct = EmptyStruct, c_style_enum = CStyleEnumVar3, mixed_enum = MixedEnumStructVar = {field1 = 121.5, field2 = -122}}}
$17 = {RUST$ENCODED$ENUM$0$1$0$0$0$0$None = Some = {{0, Vec<usize>(len: 0, cap: 0)}}}
$18 = {RUST$ENCODED$ENUM$0$0$0$0$0$0$None = Some = {""}}
A debugging session is active.

        Inferior 1 [process 2200] will be killed.

Quit anyway? (y or n) [answered Y; input not from terminal]

------------------------------------------
stderr:
------------------------------------------
Python Exception <class 'gdb.error'> Cannot convert value to int.: 
Python Exception <class 'gdb.error'> Cannot convert value to int.: 
Python Exception <class 'gdb.error'> Cannot convert value to int.: 
Python Exception <class 'gdb.error'> Cannot convert value to int.: 
Python Exception <class 'gdb.error'> Cannot convert value to int.: 
Python Exception <class 'gdb.error'> Cannot convert value to int.: 
Python Exception <class 'gdb.error'> Cannot convert value to int.: 
Python Exception <class 'gdb.error'> Cannot convert value to int.: 

------------------------------------------

thread '[debuginfo-gdb] debuginfo/gdb-pretty-struct-and-enums.rs' panicked at 'explicit panic', /home/doener/src/rust-submit/src/compiletest/runtest.rs:1490



failures:
    [debuginfo-gdb] debuginfo/gdb-pretty-struct-and-enums.rs

Seems that there is some extra, unexpected output that makes the test fail.

cc @michaelwoerister

@jdm jdm added the A-debuginfo label Aug 4, 2015

@michaelwoerister

This comment has been minimized.

Copy link
Contributor

michaelwoerister commented Aug 4, 2015

That's interesting. I'm also using GDB 7.7.1 and for me it works just fine.

@michaelwoerister

This comment has been minimized.

Copy link
Contributor

michaelwoerister commented Aug 5, 2015

@dotdash Thank you for the report! Is there anything special about the system you are getting this error on? A custom GDB version? Rust built with non-standard flags or LLVM?

bors added a commit that referenced this issue Aug 5, 2015

Auto merge of #27534 - alexcrichton:revert-adding-gdb-pp-tests, r=mic…
…haelwoerister

… are not actually broken."

This reverts commit 354cf4b.


Unfortunately these [tests are failing](http://buildbot.rust-lang.org/builders/nightly-dist-rustc-linux/builds/224/steps/distcheck/logs/stdio) on the snapshot/nightly bots with the [same message](https://gist.github.com/alexcrichton/611705ded07b0d73ded9) found in #27514
@dotdash

This comment has been minimized.

Copy link
Contributor Author

dotdash commented Aug 6, 2015

@michaelwoerister Nothing special AFAICT. GDB is just the one that currently comes with Debian Sid and Rust is built with the bundled LLVM and no special options, just disabled assertions.

@brson brson added the T-compiler label Jan 26, 2017

@brson

This comment has been minimized.

Copy link
Contributor

brson commented Jan 26, 2017

@mw Is this worth tracking? Seems like with debuggers we can't maintain perfect backcompat.

@leodasvacas

This comment has been minimized.

Copy link
Contributor

leodasvacas commented Jan 26, 2017

I assume you meant to ping @michaelwoerister

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented May 20, 2017

@michaelwoerister Should we be tracking this?

@michaelwoerister

This comment has been minimized.

Copy link
Contributor

michaelwoerister commented May 22, 2017

The test case doesn't exist anymore. We should look into writing a new one, now that we support Rust-enabled and legacy GDB versions in the test framework.

@tromey

This comment has been minimized.

Copy link
Contributor

tromey commented Nov 15, 2018

I don't think we really need any new tests here. Printing is covered reasonably well by other existing tests. Therefore, I'm closing this. Feel free to reopen if you disagree with this assessment, but if so be sure to indicate what is missing. Thanks.

@tromey tromey closed this Nov 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.