Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS packages and Windows MSIs are not signed #27694

Open
skade opened this Issue Aug 12, 2015 · 16 comments

Comments

Projects
None yet
10 participants
@skade
Copy link
Contributor

skade commented Aug 12, 2015

This possibly applies to other platforms as well.

screen shot 2015-08-12 at 14 35 56

Currently, the Rust installer comes up with this nice warning, making the user navigate to a settings pane and acknowledge to really start the installer. Administrators can also decide to completely deactivate this.

I think at least the official installers of Rust should be signed using an Apple Developer Certificate.

@nagisa

This comment has been minimized.

Copy link
Contributor

nagisa commented Aug 12, 2015

This possibly applies to other platforms as well.

All our releases and their checksums, including OS X ones, are signed with PGP signature already.

I’m not disagreeing they could also be signed using whatever method Apple for their OSes, but I'm not convinced $100/$300 is a fair price for getting rid of this dialog. OTOH we probably could piggy back on the same account used to generate signatures for Firefox.

@skade

This comment has been minimized.

Copy link
Contributor Author

skade commented Aug 12, 2015

@nagisa If that is your issue, point me to a form where I can chip in 100$ yearly. Either we want to supply installers for their platform and then do it proper or we should just ship tarballs.

@skade

This comment has been minimized.

Copy link
Contributor Author

skade commented Aug 18, 2015

I think the same is true for the windows installer.

windows unsigned

(Code signing certs for windows cost > $300 upwards, FWIW)

@brson

This comment has been minimized.

Copy link
Contributor

brson commented Aug 27, 2015

cc @edunham

Seems totally fixable in the infinite expanse of time.

@skade

This comment has been minimized.

Copy link
Contributor Author

skade commented Aug 27, 2015

I would be willing to invest time on building the signing tooling, but obviously can't help with certificate handling.

@briansmith

This comment has been minimized.

Copy link

briansmith commented Oct 24, 2015

Note that on Windows 8 and later (or, at least, Windows 8.1), Windows Safescreen makes it look like it is impossible to run the installer, and so the installation experience is terrible all around. Especially with the new MSVC port reaching Stable, it would be great to have a Good OOBE on Windows, at least for the Stable releases.

@rtoal

This comment has been minimized.

Copy link

rtoal commented Oct 26, 2015

I have the same problem on Chrome...
screen shot 2015-10-25 at 9 11 48 pm

@skade

This comment has been minimized.

Copy link
Contributor Author

skade commented Oct 26, 2015

@rtoal Just in case: you can, in the meantime, go to "Systems Settings" -> "Security and Privacy" and click the appropriate button to still start the installation process.

@skade

This comment has been minimized.

Copy link
Contributor Author

skade commented Oct 26, 2015

@brson this ticket needs A-windows as well, or should windows be split into a separate issue?

@rtoal

This comment has been minimized.

Copy link

rtoal commented Oct 26, 2015

@skade Thanks but I just used homebrew which also has 1.3.0. :)

@skade

This comment has been minimized.

Copy link
Contributor Author

skade commented Jul 1, 2016

I'd like to bump this again, also, Servo has the same issue and cannot be easily run on OS X, as it is unsigned.

@Manishearth

This comment has been minimized.

Copy link
Member

Manishearth commented Jul 1, 2016

OTOH we probably could piggy back on the same account used to generate signatures for Firefox.

I doubt this would be accepted by the Firefox people. You want your private keys locked down, having two projects with independent infrastructure share a key sounds like a bad idea. I think both Rust and Servo can get their own. Not sure if it should be the same one.

@skade

This comment has been minimized.

Copy link
Contributor Author

skade commented Jul 1, 2016

For reference, here's the issue for windows. #25457

@brson

This comment has been minimized.

Copy link
Contributor

brson commented Jul 1, 2016

Agree this is something we should solve soon.

@alexcrichton alexcrichton added the P-low label Aug 22, 2016

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented May 12, 2017

@brson I don't think this has been solved for either macOS or Windows. Could you give an update on this?

@Mark-Simulacrum Mark-Simulacrum changed the title OS X package is not signed macOS packages and Windows MSIs are not signed Jun 22, 2017

@steveklabnik

This comment has been minimized.

Copy link
Member

steveklabnik commented Mar 16, 2019

Triage: not aware of any changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.