Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upTracking issue for `path_ext` stabilization #27725
Comments
aturon
added
T-libs
B-unstable
A-io
labels
Aug 12, 2015
This comment has been minimized.
This comment has been minimized.
|
This trait was also recently tweaked to have a bit of a more coherent design, so we may just want to decide whether that strategy is appropriate or not. |
Ms2ger
referenced this issue
Aug 16, 2015
Open
Tracking: Unstable Rust feature gates used by Servo #5286
aturon
added
the
I-nominated
label
Sep 23, 2015
This comment has been minimized.
This comment has been minimized.
|
Nominating: this should at least be discussed for possible FCP in the 1.5 cycle. |
This comment has been minimized.
This comment has been minimized.
|
This issue is now entering its cycle-long FCP for stabilization in 1.5 On final question about this issue is whether we continue to have an extension trait or fold the functionality to inherent methods on
|
alexcrichton
added
final-comment-period
and removed
I-nominated
labels
Sep 24, 2015
steveklabnik
added this to the 1.5 milestone
Oct 1, 2015
This comment has been minimized.
This comment has been minimized.
|
I don't know about migration to libcore, but folding into I'm not sure if there are any users of |
This comment has been minimized.
This comment has been minimized.
|
It's also worth noting that this trait originated when there was a separate I'm increasingly convinced that treating this as an extension trait is not actually buying us anything, and winds up being a papercut for newcomers. |
This comment has been minimized.
This comment has been minimized.
|
I'm pretty much okay with the methods that |
This comment has been minimized.
This comment has been minimized.
|
The libs team discussed this during triage today and the decision was to stabilize as inherent methods on |
aturon commentedAug 12, 2015
The
PathExttrait provides a number of methods on paths that conveniently connect it to thestd::fsAPI.While these methods are largely fine, there is some question as to how many of them there should be; the rationale for the exact selection of methods is currently a bit muddy.
Given that the trait can grow over time with default methods, it may be worth stabilizing the portion we feel confident we want, and then adding more over time.
cc @alexcrichton @brson