Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upno_debug and omit_gdb_pretty_printer_sections attributes exist and are ungated #28091
Comments
huonw
added
E-easy
A-attributes
I-nominated
A-stability
T-compiler
labels
Aug 29, 2015
huonw
referenced this issue
Aug 29, 2015
Merged
Handle gateage of built-in attributes seperately #28077
This comment has been minimized.
This comment has been minimized.
|
Should someone implement this? |
This comment has been minimized.
This comment has been minimized.
|
These should both be feature-gated. |
This comment has been minimized.
This comment has been minimized.
|
triage: P-medium |
rust-highfive
added
P-medium
and removed
I-nominated
labels
Sep 17, 2015
nikomatsakis
added
the
E-mentor
label
Sep 17, 2015
This comment has been minimized.
This comment has been minimized.
|
Tagging with E-mentor -- I'm happy to mentor this. (nmatsakis on IRC) |
apasel422
referenced this issue
Sep 19, 2015
Merged
Feature-gate `#[no_debug]` and `#[omit_gdb_pretty_printer_section]` #28522
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Sep 20, 2015
bors
closed this
in
#28522
Sep 20, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
huonw commentedAug 29, 2015
This compiles without a peep from the compiler:
The later especially seems to be purely designed for the rust testsuite, so should probably be feature gated.
(Nominating for more discussion and some sort of priority: if the decision is made to feature gate them,fixing this should just involve changing a few lines of
src/libsyntax/feature_gate.rsand then adding the appropriatefeature(...)s to the tests that use them.)