Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIR: tracking issue for HIR-related things. #28139

Closed
nrc opened this Issue Sep 1, 2015 · 7 comments

Comments

Assignees
No one assigned
Labels
A-hir T-compiler metabug
Projects
None yet
Milestone
No milestone
5 participants
@nrc @eddyb @Manishearth @steveklabnik @nikomatsakis
@nrc
Copy link
Member

nrc commented Sep 1, 2015

Initial landing: #28138

@nrc nrc added the T-compiler label Sep 1, 2015

@nrc

This comment has been minimized.

Sign in to view
Copy link
Member Author

nrc commented Sep 1, 2015 •
edited by nikomatsakis

  • #28140 move desugaring to lowering step
  • #28141 unify literals and attributes
  • #28142 delete the AST after lowering
  • #28143 cache lowering info
  • #28144 remove ids from the AST
  • #28145 separate AST and HIR lints
  • #28644 move lifetime elision to HIR lowering
@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member

eddyb commented Sep 1, 2015

cc @rust-lang/compiler
@Manishearth

This comment has been minimized.

Sign in to view
Copy link
Member

Manishearth commented Sep 3, 2015

We may also want to reexport Ident and NodeId through HIR
@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member

eddyb commented Sep 3, 2015

@Manishearth Ident has the overhead of hygiene information, maybe we could use only Name in the HIR (or some sort of general interned string index Symbol - that's just a naming concern though).

And NodeId will probably be split into per-node-type IDs.
@Manishearth

This comment has been minimized.

Sign in to view
Copy link
Member

Manishearth commented Sep 3, 2015

Yeah, that works. Also we need to reexport Name, forgot about that one.

@nrc nrc added the A-hir label Sep 14, 2015

@petrochenkov petrochenkov referenced this issue Sep 17, 2015

Closed

After libsyntax, idents should be replaced by Names #6993

@steveklabnik

This comment has been minimized.

Sign in to view
Copy link
Member

steveklabnik commented Mar 8, 2017

Triage: this is a metabug. I updated some of @nrc's checkboxes from above.

@steveklabnik steveklabnik added the metabug label Mar 8, 2017

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Mar 16, 2017

I think we can close this bug, the transition to HIR is effectively complete.

@nikomatsakis nikomatsakis closed this Mar 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.