Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsafe const fn declaration order #29107

Closed
brson opened this Issue Oct 16, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@brson
Copy link
Contributor

brson commented Oct 16, 2015

The recent implementation uses the syntax unsafe const fn, but the RFC says const unsafe fn.

@thepowersgang

This comment has been minimized.

Copy link
Contributor

thepowersgang commented Oct 17, 2015

Actually, the RFC text says unsafe const fn, but a comment on the PR says const unsafe fn

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Oct 23, 2015

Discussed in the lang meeting today and decided we might as well stick to our decision, arbitrary though it may have been, and thus we should accept only const unsafe fn. I think that most of us would prefer to actually accept modifiers in any order, but it seems weird to accept just these two particular modifiers in any order, and thus we should just open a more general RFC about allowing arbitrary modifiers to appear in any order.

thepowersgang added a commit to thepowersgang/rust that referenced this issue Oct 24, 2015

@thepowersgang

This comment has been minimized.

Copy link
Contributor

thepowersgang commented Oct 24, 2015

I'm doing a final compilation check on the commit above, once it's done I'll file a PR reversing the order.

thepowersgang added a commit to thepowersgang/rust-lang_rfcs that referenced this issue Oct 24, 2015

thepowersgang added a commit to thepowersgang/rust that referenced this issue Oct 24, 2015

thepowersgang added a commit to thepowersgang/rust that referenced this issue Oct 25, 2015

@thepowersgang

This comment has been minimized.

Copy link
Contributor

thepowersgang commented Oct 25, 2015

RFC update PR rust-lang/rfcs#1335 and implementation update #29274

nikomatsakis added a commit to rust-lang/rfcs that referenced this issue Oct 26, 2015

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Oct 29, 2015

Done in #29274

arcnmx added a commit to arcnmx/rust that referenced this issue Nov 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.