Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ICEs to Glacier #29249

Closed
steveklabnik opened this Issue Oct 23, 2015 · 36 comments

Comments

Projects
None yet
8 participants
@steveklabnik
Copy link
Member

steveklabnik commented Oct 23, 2015

My Glacier repository is tracking our ICEs. Once per day, a Travis build confirms that the example still causes an ICE.

@Manishearth suggested I make a metabug here, so if you're looking for an easy way to contribute, this is it! I'm willing to mentor anyone who needs help.

https://github.com/rust-lang/rust/issues?q=is%3Aopen+is%3Aissue+label%3AI-ICE is the list of bugs. Here's a tracking list of which ones that have been added:

@bltavares

This comment has been minimized.

Copy link
Contributor

bltavares commented Oct 23, 2015

I don't know how to reproduce #29249 on CI, as it requires a PII computer apparently.

@Gankro

This comment has been minimized.

Copy link
Contributor

Gankro commented Oct 23, 2015

@bltavares you appear to have linked to this issue itself?

@bltavares

This comment has been minimized.

Copy link
Contributor

bltavares commented Oct 23, 2015

@Gankro my bad #14441

@steveklabnik

This comment has been minimized.

Copy link
Member Author

steveklabnik commented Oct 23, 2015

@bltavares hmmm, yes, that's a tough one. Maybe it's too much effort, and should just be checked off the list?

@bltavares

This comment has been minimized.

Copy link
Contributor

bltavares commented Oct 23, 2015

@steveklabnik I think it makes sense to be checked here. What about adding a note to skip certain ICEs on Glacier?

@steveklabnik

This comment has been minimized.

Copy link
Member Author

steveklabnik commented Oct 23, 2015

I checked it off and left a note.

@bltavares

This comment has been minimized.

Copy link
Contributor

bltavares commented Oct 23, 2015

#15522 is a Windows bug and the initial files used to report the issue are not available anymore.

@bltavares

This comment has been minimized.

Copy link
Contributor

bltavares commented Oct 24, 2015

#18937 Does not produce ICE, but is unsound according to the discussion and would better produce ICE.

@bltavares

This comment has been minimized.

Copy link
Contributor

bltavares commented Oct 24, 2015

#18953 Is stale and needs test case. Was initially found on Zinc.

@bltavares

This comment has been minimized.

Copy link
Contributor

bltavares commented Oct 24, 2015

#19497 Has no code to reproduce. Not sure what to do over there.

@bltavares

This comment has been minimized.

Copy link
Contributor

bltavares commented Oct 24, 2015

#19500 Has no code to reproduce.

@bltavares

This comment has been minimized.

Copy link
Contributor

bltavares commented Oct 24, 2015

#19635 Has no code to reproduce.

@bltavares

This comment has been minimized.

Copy link
Contributor

bltavares commented Oct 24, 2015

#19675 has been closed already.

@emoon

This comment has been minimized.

Copy link
Contributor

emoon commented Oct 24, 2015

#26886 Doesn't seem to be an issue anymore and is marked with E-needstest

@steveklabnik

This comment has been minimized.

Copy link
Member Author

steveklabnik commented Oct 24, 2015

Thank you both for all of your work here! This is great 💯

@bltavares

This comment has been minimized.

Copy link
Contributor

bltavares commented Oct 25, 2015

@steveklabnik Thanks for showing a simple way to contribute back. (:

@bltavares

This comment has been minimized.

Copy link
Contributor

bltavares commented Oct 25, 2015

#20767 Is stale and needs a compiling example

@bltavares

This comment has been minimized.

Copy link
Contributor

bltavares commented Oct 25, 2015

#21275 Is stale and needs an example code

@bltavares

This comment has been minimized.

Copy link
Contributor

bltavares commented Oct 25, 2015

#21321 The author says it could have been fixed already, but the author is not sure (nor am I)

@bltavares

This comment has been minimized.

Copy link
Contributor

bltavares commented Oct 25, 2015

#21349 Is stale and needs a small reproducible example.

@wheals

This comment has been minimized.

Copy link
Contributor

wheals commented Oct 25, 2015

#21461 was closed as fixed by #26667.

@bltavares

This comment has been minimized.

Copy link
Contributor

bltavares commented Oct 28, 2015

#24956 has been closed by #29284

@emoon

This comment has been minimized.

Copy link
Contributor

emoon commented Oct 28, 2015

This one has been closed #24957

@bltavares

This comment has been minimized.

Copy link
Contributor

bltavares commented Oct 28, 2015

#24947 No loger ICE

@bltavares

This comment has been minimized.

Copy link
Contributor

bltavares commented Oct 31, 2015

#23370 has been closed already.

@pointlessone pointlessone referenced this issue Oct 31, 2015

Closed

22781 #112

@bltavares

This comment has been minimized.

Copy link
Contributor

bltavares commented Nov 3, 2015

#23003 has been closed.

@ville-h

This comment has been minimized.

Copy link
Contributor

ville-h commented Nov 4, 2015

https://github.com/steveklabnik/glacier/blob/master/src/27954.rs appears to have been added but not marked as such

@tamird

This comment has been minimized.

Copy link
Contributor

tamird commented Nov 10, 2015

#24956 is incorrectly marked; this issue was never resolved and is reopened.

@steveklabnik

This comment has been minimized.

Copy link
Member Author

steveklabnik commented Nov 10, 2015

whoops! must have messed that up :(

@wldcordeiro

This comment has been minimized.

Copy link

wldcordeiro commented Nov 19, 2015

I'll take on a couple if someone can mentor, I really want to learn me some more Rust by contributing to Rust. 😄

@steveklabnik

This comment has been minimized.

Copy link
Member Author

steveklabnik commented Nov 19, 2015

@wldcordeiro sure thing! Basically, pick one of the unchecked things, find the code that causes the compiler to crash, and then make a PR to steveklabnik/glacier that looks like this: https://github.com/steveklabnik/glacier/blob/master/src/15694.rs

File name is the issue number, and it's just the code. I can help with any questions if you need any of that explained further, or I can help in real time if you drop by IRC.

@wldcordeiro

This comment has been minimized.

Copy link

wldcordeiro commented Nov 19, 2015

@steveklabnik

This comment has been minimized.

Copy link
Member Author

steveklabnik commented Nov 19, 2015

Thank you! Checked those off the list.

@emoon

This comment has been minimized.

Copy link
Contributor

emoon commented Nov 21, 2015

I did a pass on the remaining issues in the list. All of them are non-trivial to add to the current way the tests are being done now and can't be reproduced with a single source file.

So I'm not sure what would be the best way to proceed on the remaining issues without trying to make the testing script a bit more advanced (needs to be able to clone stuff on git, run cargo, or compile with rustc using specific flags to trigger issues in some cases)

@emoon

This comment has been minimized.

Copy link
Contributor

emoon commented Jan 16, 2016

Seems that #29052 is closed now

@steveklabnik

This comment has been minimized.

Copy link
Member Author

steveklabnik commented May 24, 2016

This list is basically done, I think; the remaining ones are not automatable. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.