Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach the makefile to mix in additional 'extra filename' information #29559

Closed
brson opened this Issue Nov 4, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@brson
Copy link
Contributor

brson commented Nov 4, 2015

Some systems, like Gentoo, want to package multiple versions of the Rust compiler along side each other. There are several obstacles to this, but the obvious one is that the installed Rust crates need to not have conflicting names. While we have a mechanism for this --filename-extra, the extra strings appended by the current makefile are not sufficient to discriminate between arbitrary compiler revisions.

Most likely we will add a configure switch that specifies an additional string to hash into the filename extra, in addition to what we're already hashing.

re https://internals.rust-lang.org/t/perfecting-rust-packaging-the-plan/2767

@brson brson added the A-build label Nov 4, 2015

brson added a commit to brson/rust that referenced this issue Dec 29, 2015

configure: Add --extra-filename flag
This mixes in additional information into the hash that is
passed to -C extra-filename. It can be used to further distinguish
the standard libraries if they must be installed next to each
other.

Closes rust-lang#29559

brson added a commit to brson/rust that referenced this issue Dec 29, 2015

configure: Add --extra-filename flag
This mixes in additional information into the hash that is
passed to -C extra-filename. It can be used to further distinguish
the standard libraries if they must be installed next to each
other.

Closes rust-lang#29559

bors added a commit that referenced this issue Jan 12, 2016

Auto merge of #30599 - brson:extra, r=alexcrichton
This mixes in additional information into the hash that is
passed to -C extra-filename. It can be used to further distinguish
the standard libraries if they must be installed next to each
other.

Closes #29559

Frankly, I'm not sure if this solves a real problem. It's meant to help with side-by-side and overlapping installations where there are two sets of libs in /usr, but there are other potential issues there as well, including that some of our artifacts don't use this extra-filename munging, and it's not something our installers can support at all.

cc @jauhien Do you still think this helps the Gentoo case?

@bors bors closed this in #30599 Jan 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.