New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --libdir issues #29561

Closed

brson opened this Issue Nov 4, 2015 · 1 comment

Contributor

brson commented Nov 4, 2015

The way rust and rust-installer handles --libdir is broken, and at least in Gentoo's case is unusable without patching.

See Gentoo's rust-installer patch. And an old rust-installer PR.

re https://internals.rust-lang.org/t/perfecting-rust-packaging-the-plan/2767

steveklabnik added the A-build label Nov 4, 2015

Contributor

wthrowe commented Nov 10, 2015

It appears that --libdir fails on recent nightlys even with Gentoo's patch: gentoo/gentoo-rust#29

wthrowe added a commit to wthrowe/rust that referenced this issue Nov 16, 2015


      Fix --libdir installs

Rather than modifying the installer to disable directory rewriting,
this patch modifies the directory structure passed to the installer so
that the rewriting gives the correct results.  This means that if a
non-standard --libdir is passed to configure then the same --libdir
option (relative to the --prefix) must be passed to the install
script.  In the `make install` case this is handled automatically.
Binary distributions are generally generated using the default
--libdir and then have paths optionally rewritten by the installer,
which should continue to work.

This has the advantage of not complicating the installer interface
intended for end-user use.

Fixes rust-lang#29561

ea798b9

wthrowe referenced this issue Nov 16, 2015

Merged

Fix --libdir installs #29878

bors added a commit that referenced this issue Nov 18, 2015


      Auto merge of #29878 - wthrowe:libdir2, r=brson

Rather than modifying the installer to disable directory rewriting,
this patch modifies the directory structure passed to the installer so
that the rewriting gives the correct results.  This means that if a
non-standard --libdir is passed to configure then the same --libdir
option (relative to the --prefix) must be passed to the install
script.  In the `make install` case this is handled automatically.
Binary distributions are generally generated using the default
--libdir and then have paths optionally rewritten by the installer,
which should continue to work.

This has the advantage of not complicating the installer interface
intended for end-user use.

Fixes #29561

edcfeb7

bors closed this in #29878 Nov 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.