Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mir: Trans of fn calls unimplemented #29575

Closed
nikomatsakis opened this Issue Nov 4, 2015 · 1 comment

Comments

Assignees

@nikomatsakis nikomatsakis

Labels
A-mir P-medium T-compiler
Projects
None yet
Milestone
No milestone
2 participants
@nikomatsakis @rust-highfive
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Nov 4, 2015

This is a big one! We need to support function calls in MIR trans.

@nikomatsakis nikomatsakis added T-compiler A-mir labels Nov 4, 2015

@nikomatsakis nikomatsakis self-assigned this Nov 4, 2015

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nikomatsakis commented Nov 4, 2015

triage: P-medium

@rust-highfive rust-highfive added the P-medium label Nov 4, 2015

@nikomatsakis nikomatsakis referenced this issue Nov 4, 2015

Closed

Tracking issue for MIR (RFC #1211) #27840

8 of 16 tasks complete

@luqmana luqmana referenced this issue Dec 13, 2015

Merged

[MIR] Initial implementation for translating calls. #30364

@nagisa nagisa referenced this issue Dec 19, 2015

Merged

[MIR] Refine representation and translation of calls #30481

bors added a commit that referenced this issue Jan 6, 2016

@bors
Auto merge of #30481 - nagisa:mir-calls-2, r=nikomatsakis 
r? @nikomatsakis

This is a pretty big PR conflating changes to a few different block terminators (Call, DivergingCall, Panic, Resume, Diverge), because they are somewhat closely related.

Each commit has a pretty good description on what is being changed in each commit. The end result is greatly simplified CFG and translation for calls (no success branch if the function is diverging, no cleanup branch if there’s nothing to cleanup etc).

Fixes #30480
Related #29767
Partialy solves #29575
Fixes #29573
a9c3ffd

bors added a commit that referenced this issue Jan 6, 2016

@bors
Auto merge of #30481 - nagisa:mir-calls-2, r=nikomatsakis 
r? @nikomatsakis

This is a pretty big PR conflating changes to a few different block terminators (Call, DivergingCall, Panic, Resume, Diverge), because they are somewhat closely related.

Each commit has a pretty good description on what is being changed in each commit. The end result is greatly simplified CFG and translation for calls (no success branch if the function is diverging, no cleanup branch if there’s nothing to cleanup etc).

Fixes #30480
Fixes #29767
Partialy solves #29575
Fixes #29573
d5ac1a1

@nagisa nagisa referenced this issue Jan 12, 2016

Merged

[MIR] Implement extern call support #30845

Manishearth added a commit to Manishearth/rust that referenced this issue Jan 13, 2016

@Manishearth
Rollup merge of rust-lang#30845 - nagisa:mir-extern-calls, r=nikomats… 
…akis

Supersedes rust-lang#30517
Fixes rust-lang#29575

cc @luqmana
r? @nikomatsakis
0a5f6b8

bors added a commit that referenced this issue Jan 14, 2016

@bors
Auto merge of #30845 - nagisa:mir-extern-calls, r=<try> 
Supersedes #30517
Fixes #29575

cc @luqmana
r? @nikomatsakis
29d24a3

bors added a commit that referenced this issue Jan 14, 2016

@bors
Auto merge of #30845 - nagisa:mir-extern-calls, r=nmatsakis 
Supersedes #30517
Fixes #29575

cc @luqmana
r? @nikomatsakis
eaa5059

bors added a commit that referenced this issue Jan 19, 2016

@bors
Auto merge of #30845 - nagisa:mir-extern-calls, r=dotdash 
Supersedes #30517
Fixes #29575

cc @luqmana
r? @nikomatsakis
41b74b1

@bors bors closed this in #30845 Jan 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.