Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for `visible_private_types` feature #29627

Closed
aturon opened this Issue Nov 5, 2015 · 0 comments

Comments

Assignees
No one assigned
Labels
B-unstable T-lang
Projects
None yet
Milestone
No milestone
1 participant
@aturon
@aturon
Copy link
Member

aturon commented Nov 5, 2015

The visible_private_types feature allows exposing private types in public signatures (in contravention of RFC 136). This feature should probably be removed.

@aturon aturon added T-lang B-unstable labels Nov 5, 2015

@petrochenkov petrochenkov referenced this issue Nov 21, 2015

Merged

privacy: Rewrite VisiblePrivateTypesVisitor #29973

bors added a commit that referenced this issue Dec 18, 2015

@bors
Auto merge of #29973 - petrochenkov:privinpub, r=nikomatsakis 
Some notes:
This patch enforces the rules from [RFC 136](https://github.com/rust-lang/rfcs/blob/master/text/0136-no-privates-in-public.md) and makes "private in public" a module-level concept and not crate-level. Only `pub` annotations are used by the new algorithm, crate-level exported node set produced by `EmbargoVisitor` is not used. The error messages are tweaked accordingly and don't use the word "exported" to avoid confusing people (#29668).

The old algorithm tried to be extra smart with impls, but it mostly led to unpredictable behavior and bugs like #28325.
The new algorithm tries to be as simple as possible - an impl is considered public iff its type is public and its trait is public (if presents).
A type or trait is considered public if all its components are public, [complications](https://internals.rust-lang.org/t/limits-of-type-inference-smartness/2919) with private types leaking to other crates/modules through trait impls and type inference are deliberately ignored so far.

The new algorithm is not recursive and uses the nice new facility `Crate::visit_all_items`!

Obsolete pre-1.0 feature `visible_private_types` is removed.

This is a [breaking-change].
The two main vectors of breakage are type aliases (#28450) and impls (#28325).
I need some statistics from a crater run (cc @alexcrichton) to decide on the breakage mitigation strategy.
UPDATE: All the new errors are reported as warnings controlled by a lint `private_in_public` and lint group `future_incompatible`, but the intent is to make them hard errors eventually.

Closes #28325
Closes #28450
Closes #29524
Closes #29627
Closes #29668
Closes #30055

r? @nikomatsakis
ef91cdb

@bors bors closed this in #29973 Dec 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.