Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRe-add raw_pointer_derive lint as a no-op #30346
Comments
This comment has been minimized.
This comment has been minimized.
|
Policy-wise this is similar but (imo) different to our policy of allowing changes to lints to break code. E.g. |
This comment has been minimized.
This comment has been minimized.
|
It looks like the breakage is due to I do vaguely recall reaching the conclusion at some point, however, about not removing lints. I don't remember the reason, however, so I'd want to discuss this a bit before reverting. |
This comment has been minimized.
This comment has been minimized.
|
Two more crates broke in the latest report. |
This comment has been minimized.
This comment has been minimized.
|
Don't we have a cargo feature that ensures that warnings (lints) changes are of very low impact, i.e. don't really break things that depend on the crate, for example. |
This comment has been minimized.
This comment has been minimized.
|
Yep, lints are capped at allowed for dependencies. Changing this one to be a no-op and maybe adding a default-warn |
This comment has been minimized.
This comment has been minimized.
|
Another regression popped up in this report. accumulator-0.1.3 |
This comment has been minimized.
This comment has been minimized.
|
Also containerof-0.2.1, memory_map-0.0.3. Edit: oh accumulator and memory_map were already known from a previous report. I think containerof is new. |
This comment has been minimized.
This comment has been minimized.
|
After updating the regression sheet I count 7 crates affected by this. |
brson
self-assigned this
Jan 6, 2016
This comment has been minimized.
This comment has been minimized.
|
@nikomatsakis and I discussed that we'd prefer removed lints indicate they were removed with a warning instead of saying 'unknown lint'. I may try to get a patch together that does this. |
This comment has been minimized.
This comment has been minimized.
|
triage: P-high (it is questionable about whether this should be classified as a "regression" per se, in terms of what the impact actually is of this sort of change if you aren't opting into stronger lint settings. but anyway, we want to handle this case better.) |
rust-highfive
added
P-high
and removed
I-nominated
labels
Jan 7, 2016
This comment has been minimized.
This comment has been minimized.
|
It seems there is a mechanism for registering that a lint has been removed, why didn't we use that? I think we ought to. |
This comment has been minimized.
This comment has been minimized.
|
I will try adding it back as a removed lint and making sure it doesn't cause build failures. |
This comment has been minimized.
This comment has been minimized.
|
I've gotten in to yak shaving with the code for registering renamed and removed lints. It doesn't have test coverage and has some issues. Still expect to get a patch in. |
brson
added a commit
to brson/rust
that referenced
this issue
Jan 13, 2016
brson
added a commit
to brson/rust
that referenced
this issue
Jan 13, 2016
brson
referenced this issue
Jan 13, 2016
Merged
rustc: Fix bugs in renamed and removed lints and re-add raw_pointer_derive #30878
brson
added a commit
to brson/rust
that referenced
this issue
Jan 13, 2016
brson
added a commit
to brson/rust
that referenced
this issue
Jan 13, 2016
brson
added a commit
to brson/rust
that referenced
this issue
Jan 14, 2016
brson
added a commit
to brson/rust
that referenced
this issue
Jan 14, 2016
bors
added a commit
that referenced
this issue
Jan 15, 2016
brson
added a commit
to brson/rust
that referenced
this issue
Jan 16, 2016
This comment has been minimized.
This comment has been minimized.
|
Is this not fixed? |
This comment has been minimized.
This comment has been minimized.
|
@brson ^^ :) |
This comment has been minimized.
This comment has been minimized.
|
Done in #30878 |
brson commentedDec 11, 2015
Removed in #29882, causing breakage to maidsafe_utilities.
I recall at some point we decided never to remove lints because of this very problem and simply convert them to no-ops.