Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows linker regression in 1.6 #31151

Closed
brson opened this Issue Jan 23, 2016 · 2 comments

Comments

Projects
None yet
5 participants
@brson
Copy link
Contributor

brson commented Jan 23, 2016

As reported here.

I had a problem after upgrading from 1.5 (stable) to 1.6 (stable), so I thought I'd document the fix here. My system is Windows 10, 64-bit; Rust compiler is MSVC ABI; Visual Studio 13 Express for Desktop is installed.

After upgrading, all cargo builds failed with "link.exe could not find ws2_32.lib". The problem was that the LIB path wasn't set. Setting the environment variable LIB to:

"C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\lib\amd64"; "C:\Program Files (x86)\Windows Kits\8.1\Lib\winv6.3\um\x64" fixed the problem. Your paths may vary, of course, and you might have to add other paths if you have other missing libraries.

I'm not sure why this worked with earlier versions of Rust; it seems like it should always have failed.

@retep998 Do you know what we should change to make this work out of the box again?

@retep998

This comment has been minimized.

Copy link
Member

retep998 commented Jan 23, 2016

I have some ideas of what to do that I got after interrogating a different person on IRC about their issues. I will put together a PR that makes that code even more robust.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Feb 11, 2016

triage: P-low

@rust-highfive rust-highfive added P-low and removed I-nominated labels Feb 11, 2016

@huonw huonw added the O-windows label May 4, 2016

retep998 added a commit to retep998/rust that referenced this issue Jun 26, 2016

Make MSVC detection ludicrously robust
Should fix a few more edge cases

Fixes rust-lang#31151
Fixes rust-lang#32159
Fixes rust-lang#34484
Improves rust-lang-deprecated/rust-packaging#50

Signed-off-by: Peter Atashian <retep998@gmail.com>

retep998 added a commit to retep998/rust that referenced this issue Jun 26, 2016

Make MSVC detection ludicrously robust
Should fix a few more edge cases

Fixes rust-lang#31151
Fixes rust-lang#32159
Fixes rust-lang#34484
Improves rust-lang-deprecated/rust-packaging#50

Signed-off-by: Peter Atashian <retep998@gmail.com>

retep998 added a commit to retep998/rust that referenced this issue Jun 26, 2016

Make MSVC detection ludicrously robust
Should fix a few more edge cases

Fixes rust-lang#31151
Fixes rust-lang#32159
Fixes rust-lang#34484
Improves rust-lang-deprecated/rust-packaging#50

Signed-off-by: Peter Atashian <retep998@gmail.com>

retep998 added a commit to retep998/rust that referenced this issue Jun 27, 2016

Make MSVC detection ludicrously robust
Should fix a few more edge cases

Fixes rust-lang#31151
Fixes rust-lang#32159
Fixes rust-lang#34484
Improves rust-lang-deprecated/rust-packaging#50

Signed-off-by: Peter Atashian <retep998@gmail.com>

retep998 added a commit to retep998/rust that referenced this issue Jun 28, 2016

Make MSVC detection ludicrously robust
Should fix a few more edge cases

Fixes rust-lang#31151
Fixes rust-lang#32159
Fixes rust-lang#34484
Improves rust-lang-deprecated/rust-packaging#50

Signed-off-by: Peter Atashian <retep998@gmail.com>

@bors bors closed this in a1b33b4 Jul 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.