Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `SeekFrom` to the IO prelude #31268

Closed
forticulous opened this Issue Jan 28, 2016 · 2 comments

Comments

Assignees
No one assigned
Labels
I-nominated
Projects
None yet
Milestone
No milestone
3 participants
@forticulous @steveklabnik @aturon
@forticulous
Copy link

forticulous commented Jan 28, 2016

The IO prelude currently includes Read, Write and Seek, but in order to use Seek you almost always need SeekFrom in scope also. I think it makes sense to include SeekFrom also.

@steveklabnik steveklabnik added the A-libs label Feb 2, 2016

@steveklabnik

This comment has been minimized.

Sign in to view
Copy link
Member

steveklabnik commented Feb 2, 2016

/cc @rust-lang/libs

Adding something to the prelude is very dangerous.

@aturon aturon added the I-nominated label Feb 2, 2016

@forticulous

This comment has been minimized.

Sign in to view
Copy link
Author

forticulous commented Feb 3, 2016

It looks like the general pattern is that only traits are a part of the io prelude. So in that way it would be counter to the pattern to add an enum like SeekFrom.

@forticulous forticulous closed this Feb 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.