Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upWarn for type parameter defaults on `impl` blocks #31543
Comments
steveklabnik
added
the
A-diagnostics
label
Feb 15, 2016
This comment has been minimized.
This comment has been minimized.
|
Argh, I guess I failed to cover those? |
nikomatsakis
added
I-nominated
T-lang
T-compiler
labels
Mar 15, 2016
This comment has been minimized.
This comment has been minimized.
|
Nominating for triage. |
This comment has been minimized.
This comment has been minimized.
|
triage: P-high |
nikomatsakis
self-assigned this
Mar 17, 2016
rust-highfive
added
P-high
and removed
I-nominated
labels
Mar 17, 2016
jseyfried
referenced this issue
Apr 8, 2016
Merged
Warn for type parameter defaults on impl blocks #32817
bors
added a commit
that referenced
this issue
Apr 13, 2016
bors
closed this
in
#32817
Apr 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
bluss commentedFeb 10, 2016
If I understand correctly, type parameter defaults have no effect in the block
impl<T = default> Foo<T> { }.Just like in PR #30724, this should have a warning and then an error.
Example (playground)
cc @nikomatsakis