Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in servo-skia-0.20130412.6 build script on 1.7 beta #31586

Closed
brson opened this Issue Feb 11, 2016 · 6 comments

Comments

Projects
None yet
4 participants
@brson
Copy link
Contributor

brson commented Feb 11, 2016

Original report.

This builds on 1.6 stable but on 1.7 beta produces

failed to run custom build command for `servo-skia v0.20130412.6 (file:///home/crate)`                                  
Process didn't exit successfully: `/home/crate/target/debug/build/servo-skia-242f584507aad753/build-script-build` (exit 
code: 101)                                                                                                              
--- stdout                                                                                                              
mkdir -p /home/crate/target/debug/build/servo-skia-242f584507aad753/out/src/ports                                       
makefile.cargo:754: recipe for target '/home/crate/target/debug/build/servo-skia-242f584507aad753/out/src/ports/SkAtomic
s_sync.h' failed                                                                                                        

--- stderr                                                                                                              
mkdir: cannot create directory '/home/crate/target/debug/build/servo-skia-242f584507aad753/out/src/ports': No such file 
or directory                                                                                                            
make: *** [/home/crate/target/debug/build/servo-skia-242f584507aad753/out/src/ports/SkAtomics_sync.h] Error 1           
thread '<main>' panicked at 'assertion failed: Command::new("make").args(&["-R", "-f", "makefile.cargo",                
                            &format!("-j{}" , env:: var ( "NUM_JOBS" ) .                                                
                                     unwrap (                                                                           
                                     ))]).status().unwrap().success()', build.rs:12  

cc @alexcrichton @larsbergstrom

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Feb 11, 2016

@alexcrichton Couldn't repro this locally

@larsbergstrom

This comment has been minimized.

Copy link
Contributor

larsbergstrom commented Feb 11, 2016

Seems... curious. Skia currently builds just fine against 1.8.0 (a pretty recent nightly):
https://travis-ci.org/servo/skia/builds/106752311

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Feb 11, 2016

Because I can't reproduce this locally, seems to be working for Servo, and it kinda looks spurious, I'd probably also classify this as spurious?

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Feb 11, 2016

I also can't recall anything that would have landed in Cargo recently to cause this to break...

@sfackler

This comment has been minimized.

Copy link
Member

sfackler commented Feb 11, 2016

Looks like a one-off failure. It'd probably be worth adjusting the command invocation to record stdout and stderror and display them on failure.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Feb 12, 2016

Ok, this appears to be spurious (as confirmed by @mbrubeck as well), so I'm going to close this as likely spurious.

If, however, we see this in another crater report I can definitely try to do a more thorough investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.